oidc/callback: handle missing state param #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this check, a request without a state parameter will generate an internal server error and receive a 500-status response. This change sends the client through the proper error-handling route.
alxndrsn
commented
Feb 11, 2025
ktuite
approved these changes
Feb 12, 2025
alxndrsn
pushed a commit
to alxndrsn/odk-central-backend
that referenced
this pull request
Feb 12, 2025
These were incorrectly excluded while merging getodk#1392 & getodk#1399 into master.
alxndrsn
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check, a request without a state parameter will generate an internal server error and receive a 500-status response.
This change sends the client through the proper error-handling route.
Closes #1391
What has been done to verify that this works as intended?
Added a test!
Why is this the best possible solution? Were any other approaches considered?
This could also be an e2e test, but an integration test should run and fail faster, giving faster feedback.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This change should only affect users in unhappy paths.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
I don't think so.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes