-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2022.02.xx] module plugins PRs #8558
Merged
tdipisa
merged 9 commits into
geosolutions-it:2022.02.xx
from
alexander-fedorenko:backport-2022.02.xx-module-plugins
Sep 7, 2022
Merged
[Backport 2022.02.xx] module plugins PRs #8558
tdipisa
merged 9 commits into
geosolutions-it:2022.02.xx
from
alexander-fedorenko:backport-2022.02.xx-module-plugins
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4005b4e)
…solutions-it#8495) (cherry picked from commit 5756dd4)
… so that muteState has all the epics listed correctly. (geosolutions-it#8514) (cherry picked from commit 20ca575)
…geosolutions-it#8550) * Properly resolve issue when internal PluginsContainer cause part of the plugins being muted on the same page. Relevant for context creator map viewer or any inline map viewers. * Two new tests to make sure that epics will be muted whenever window.location.hash changes and won't be muted otherwise on subsequent plugins reloads (e.g. for nested plugin containers) (cherry picked from commit ce960b4)
…process (geosolutions-it#8472) (cherry picked from commit 36ee6e5)
…n. (geosolutions-it#8544) * geosolutions-it#8543 Make tutorial compatible with being module plugin. - Improved REDUCERS_LOADED action to make it pass list of added reducers as a payload. - Updated switchTutorialEpic to make it actually triggered once tutorial reducer is added & one of the subsequent actions dispatched. * Rely only on router information from state. Plausibly because of the mute/unmute of the epics one of the LOCATION_CHANGE events is getting skipped, it makes inline stream gets incorrect information about current router in this case. Information from state is more reliable. * Moving action creator into separate file, amending jsdoc * Amended tests to use state value. (cherry picked from commit 7567d12)
…ll plugins are loaded (geosolutions-it#8538) (cherry picked from commit 854c32c)
…olutions-it#8531) (cherry picked from commit a7c626b)
…-it#8553) * geosolutions-it#8551 fix dashboard embedded crash error * fix crash on observables for dashboard (cherry picked from commit 91cc6bf)
MV88
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on a commits point of view.
DO NOT SQUASH AND MERGE
tdipisa
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a cumulative backport including changes from the following PRs:
#8457 (#8423)
#8495 (#8503)
#8514 (#8513)
#8550 (#8483 #8481)
#8544 (#8543)
#8538 (#8534)
#8472 (#8454)
#8531 (#8535)
#8553 (#8553)