Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2022.02.xx] module plugins PRs #8558

Conversation

alexander-fedorenko
Copy link
Contributor

Description

This is a cumulative backport including changes from the following PRs:
#8457 (#8423)
#8495 (#8503)
#8514 (#8513)
#8550 (#8483 #8481)
#8544 (#8543)
#8538 (#8534)
#8472 (#8454)
#8531 (#8535)
#8553 (#8553)

alexander-fedorenko and others added 9 commits September 7, 2022 07:19
… so that muteState has all the epics listed correctly. (geosolutions-it#8514)

(cherry picked from commit 20ca575)
…geosolutions-it#8550)

* Properly resolve issue when internal PluginsContainer cause part of the plugins being muted on the same page. Relevant for context creator map viewer or any inline map viewers.

* Two new tests to make sure that epics will be muted whenever window.location.hash changes and won't be muted otherwise on subsequent plugins reloads (e.g. for nested plugin containers)

(cherry picked from commit ce960b4)
…n. (geosolutions-it#8544)

* geosolutions-it#8543 Make tutorial compatible with being module plugin.

- Improved REDUCERS_LOADED action to make it pass list of added reducers as a payload.
- Updated switchTutorialEpic to make it actually triggered once tutorial reducer is added & one of the subsequent actions dispatched.

* Rely only on router information from state. Plausibly because of the mute/unmute of the epics one of the LOCATION_CHANGE events is getting skipped, it makes inline stream gets incorrect information about current router in this case. Information from state is more reliable.

* Moving action creator into separate file, amending jsdoc

* Amended tests to use state value.

(cherry picked from commit 7567d12)
…-it#8553)

* geosolutions-it#8551 fix dashboard embedded crash error

* fix crash on observables for dashboard

(cherry picked from commit 91cc6bf)
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on a commits point of view.

DO NOT SQUASH AND MERGE

@tdipisa tdipisa merged commit ba30a0a into geosolutions-it:2022.02.xx Sep 7, 2022
@offtherailz offtherailz added this to the v2022.02.00 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants