Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8513 Properly pass epic name into isolation function, so that muteState has all the epics listed correctly. #8514

Conversation

alexander-fedorenko
Copy link
Contributor

@alexander-fedorenko alexander-fedorenko commented Aug 29, 2022

Description

There is an issue preventing epics from being muted correctly because epics name is not passed as an argument into function that creates RxJS subject per epic.
Also, when plugin name is not normalized in plugins.js, mute of the epic can't happen properly under specific conditions.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#8513

What is the new behavior?
Mute/unmute action is managed properly regardless of plugin name. All epics are isolated properly.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

… etc.) to make mute/unmute works regardless of plugin name (normalized or not)
@alexander-fedorenko alexander-fedorenko added bug Priority: Blocker BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C169-Rennes-Métropole-2021-GeOrchestra3 labels Aug 29, 2022
@alexander-fedorenko alexander-fedorenko self-assigned this Aug 29, 2022
@alexander-fedorenko
Copy link
Contributor Author

Hi @allyoucanmap, please review it when convenient.
As previously discussed, test coverage is extended now to cover storeManager main use-cases.

@allyoucanmap allyoucanmap changed the title Properly pass epic name into isolation function, so that muteState has all the epics listed correctly. #8513 Properly pass epic name into isolation function, so that muteState has all the epics listed correctly. Sep 1, 2022
@allyoucanmap allyoucanmap merged commit 20ca575 into geosolutions-it:master Sep 1, 2022
@allyoucanmap
Copy link
Contributor

@tdipisa there is not a specific test to do for this on the DEV, this is related to the new store API. We could verify if the application is loading as usual

@tdipisa
Copy link
Member

tdipisa commented Sep 1, 2022

@tdipisa there is not a specific test to do for this on the DEV, this is related to the new store API. We could verify if the application is loading as usual

@ElenaGallo please proceed as usual in DEV and let us know for the backport. Thank you @allyoucanmap.

@ElenaGallo
Copy link
Contributor

Test passed on DEV, @allyoucanmap please backport to stable branch. Thanks

alexander-fedorenko added a commit to alexander-fedorenko/MapStore2 that referenced this pull request Sep 5, 2022
… so that muteState has all the epics listed correctly. (geosolutions-it#8514)

(cherry picked from commit 20ca575)
@alexander-fedorenko
Copy link
Contributor Author

@tdipisa, @ElenaGallo this cannot be effectively backported to 2022.02.xx because #8457 (comment) is not yet backported.

@tdipisa
Copy link
Member

tdipisa commented Sep 5, 2022

@tdipisa, @ElenaGallo this cannot be effectively backported to 2022.02.xx because #8457 (comment) is not yet backported.

Yes I know @alexander-fedorenko. Why did you backport it anyway without providing a backport also for 8457?

@ElenaGallo before backporting #8457 all tests for #8503 must pass.

alexander-fedorenko added a commit to alexander-fedorenko/MapStore2 that referenced this pull request Sep 7, 2022
… so that muteState has all the epics listed correctly. (geosolutions-it#8514)

(cherry picked from commit 20ca575)
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 7, 2022
@offtherailz offtherailz added this to the v2022.02.00 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants