-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8513 Properly pass epic name into isolation function, so that muteState has all the epics listed correctly. #8514
#8513 Properly pass epic name into isolation function, so that muteState has all the epics listed correctly. #8514
Conversation
…s all the epics listed correctly.
… etc.) to make mute/unmute works regardless of plugin name (normalized or not)
Hi @allyoucanmap, please review it when convenient. |
@tdipisa there is not a specific test to do for this on the DEV, this is related to the new store API. We could verify if the application is loading as usual |
@ElenaGallo please proceed as usual in DEV and let us know for the backport. Thank you @allyoucanmap. |
Test passed on DEV, @allyoucanmap please backport to stable branch. Thanks |
… so that muteState has all the epics listed correctly. (geosolutions-it#8514) (cherry picked from commit 20ca575)
@tdipisa, @ElenaGallo this cannot be effectively backported to 2022.02.xx because #8457 (comment) is not yet backported. |
Yes I know @alexander-fedorenko. Why did you backport it anyway without providing a backport also for 8457? @ElenaGallo before backporting #8457 all tests for #8503 must pass. |
… so that muteState has all the epics listed correctly. (geosolutions-it#8514) (cherry picked from commit 20ca575)
Description
There is an issue preventing epics from being muted correctly because epics name is not passed as an argument into function that creates RxJS subject per epic.
Also, when plugin name is not normalized in plugins.js, mute of the epic can't happen properly under specific conditions.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8513
What is the new behavior?
Mute/unmute action is managed properly regardless of plugin name. All epics are isolated properly.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information