-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8503 Bugs related modular plugins implementation #8495
#8503 Bugs related modular plugins implementation #8495
Conversation
…. This allows to pass full list of plugins to the nested PluginsContainer components
… it again from another plugin.
…ure that if at least one plugin intended to register epic and such plugin is on the page - epic will not be muted.
9ebe144
to
504590e
Compare
… map, context, dashboard, geostory.
…odule plugins are loaded at once.
…low changes: context creator page performs reset of context & load of new configuration once plugins are loaded. This happens after contextcreator\ContextCreator component was mounted and forces reset of tutorials list. Added check on componentDidUpdate resolves delayed reset issue.
…er state." This reverts commit 951a1cb.
…at all module plugins are loaded at once." This reverts commit 09fdf3f
…ad maps, map, context, dashboard, geostory." This reverts commit a1fb9eb.
@ElenaGallo please test this dev and let me know if I can backport, thanks |
1_ After testing the #8481 I found this: I can not save the map from the MAP EDITOR INLINE How to reproduce
Current Result 2_ After testing the #8483 I found this: For the second steps of the wizard, the tutorial start at the beginning but then when I click on Show Tutorial button the tutorial does not start and for the third steps of the wizard, the tutorial does not start and when I click on Show Tutorial button the tutorial does not start. How to reproduceSee the gif below: editing_annotations.mov |
Hi @ElenaGallo, thanks! I'll take a look on first point. |
@alexander-fedorenko as I said in the call, consider that now when I click on OK nothing happens while if I click on Cancel I am brought in the same state of OK. This is an additional caveat. |
…solutions-it#8495) (cherry picked from commit 5756dd4)
Description
Bugfixes for regression issues after implementation of #8457
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
PR applies changes to resolve following issues:
#8476
#8477
#8478
#8479
#8480
#8481
#8482
#8483
#8484
What is the new behavior?
Regressions from issues listed above are resolved.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information