Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8503 Bugs related modular plugins implementation #8495

Merged

Conversation

alexander-fedorenko
Copy link
Contributor

@alexander-fedorenko alexander-fedorenko commented Aug 18, 2022

Description

Bugfixes for regression issues after implementation of #8457

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
PR applies changes to resolve following issues:
#8476
#8477
#8478
#8479
#8480
#8481
#8482
#8483
#8484

What is the new behavior?
Regressions from issues listed above are resolved.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@alexander-fedorenko alexander-fedorenko self-assigned this Aug 18, 2022
…low changes: context creator page performs reset of context & load of new configuration once plugins are loaded. This happens after contextcreator\ContextCreator component was mounted and forces reset of tutorials list. Added check on componentDidUpdate resolves delayed reset issue.
…at all module plugins are loaded at once."

This reverts commit 09fdf3f
…ad maps, map, context, dashboard, geostory."

This reverts commit a1fb9eb.
@alexander-fedorenko alexander-fedorenko marked this pull request as ready for review August 22, 2022 10:33
@allyoucanmap allyoucanmap changed the title 523 Regression bug fixes #8503 Bugs related modular plugins implementation Aug 22, 2022
@allyoucanmap allyoucanmap merged commit 5756dd4 into geosolutions-it:master Aug 22, 2022
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test this dev and let me know if I can backport, thanks

@allyoucanmap allyoucanmap added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C169-Rennes-Métropole-2021-GeOrchestra3 labels Aug 22, 2022
@ElenaGallo
Copy link
Contributor

@alexander-fedorenko

1_ After testing the #8481 I found this:

I can not save the map from the MAP EDITOR INLINE

How to reproduce

  • Login as admin
  • Click on new geostory
  • Click on Change Media Source
  • Click on Maps tab
  • Click on +
  • Click on OK

Current Result
The Ok button is not clickable

2_ After testing the #8483 I found this:

For the second steps of the wizard, the tutorial start at the beginning but then when I click on Show Tutorial button the tutorial does not start and for the third steps of the wizard, the tutorial does not start and when I click on Show Tutorial button the tutorial does not start.

How to reproduce

See the gif below:

editing_annotations.mov

@alexander-fedorenko
Copy link
Contributor Author

alexander-fedorenko commented Sep 5, 2022

Hi @ElenaGallo, thanks! I'll take a look on first point.
Issue with tutorial should be covered with #8544, I will double-check it

@tdipisa
Copy link
Member

tdipisa commented Sep 5, 2022

1_ After testing the #8481 I found this:

@alexander-fedorenko as I said in the call, consider that now when I click on OK nothing happens while if I click on Cancel I am brought in the same state of OK. This is an additional caveat.

alexander-fedorenko added a commit to alexander-fedorenko/MapStore2 that referenced this pull request Sep 7, 2022
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 7, 2022
@offtherailz offtherailz added this to the v2022.02.00 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants