Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 ➡️ 5 #622

Merged
merged 73 commits into from
Mar 3, 2021
Merged

4 ➡️ 5 #622

merged 73 commits into from
Mar 3, 2021

Conversation

chapulina
Copy link
Contributor

Port ign-gazebo4 to main

Branch comparison: main...ign-gazebo4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

caguero and others added 30 commits December 23, 2020 22:18
@caguero
New ParticleEmitter component.
4a9aca8 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Remove attribute name.
272d39b 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Merge branch 'ign-gazebo4' into particle_system
fb0c084
@caguero
Update particle emitter component to use ignition::msgs::ParticleEmit…
698bb1e 
…ter.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Merge
24261cf 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Merge branch 'ign-gazebo4' into particle_system
f5538d5
@mjcarroll @chapulina
Automatically load a subset of world plugins (#281)
6b6f76f 
Feature to allow loading of a default set of system plugins from a file. This behavior will trigger when a world sdf file is loaded with no plugins defined.  In this case, the simulator will load the plugins from a series of locations including environment variable, the users home folder, and finally in the installation directory.

This should allow users to not have to specify the same set of plugins in every world sdf file.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@nkoenig
Added missing version namespace (#541)
69e190c 
* Added missing version namespace

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Fix codecheck

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
@nlamprian
Fix examples in migration plugins tutorial (#543)
6544c78 
Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com>
@nkoenig
Prepare for 3.7.0 release (#552)
d5e65d9 
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
@chapulina
Non-blocking paths request (#555)
4124dea 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Parallelize State call in ECM (#451)
ddd7fcd 
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@jennuine
added size to ground_plane in examples (#573)
8998740 
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@luca-della-vedova
Publish all periodic change components in Scene Broadcaster (#544)
afb228d 
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@iche033
Backport state update changes from pull request #486 (#583)
347fd51 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@brawner
Fix code_check errors (#582)
8fd9b26 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@jennuine
Visualize collisions (#531)
ebd09d4 
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
@mabelzhang
Remove playback <path> SDF param in Dome (#570)
59ea1c6 
* change system injected playback path tag; update documentation
* Remove <path> SDF param for LogPlayback
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: John Shepherd <john@openrobotics.org>
@caguero
Merge branch 'ign-gazebo4' into particle_system
0a26d4e
@caguero
Simplify particle emitter component.
4cbc9dd 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@chapulina @mjcarroll
Tutorial on migrating SDF files from Gazebo classic (#400)
39e98e1 
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Michael Carroll <michael@openrobotics.org>
@gonzodepedro @chapulina
World exporter (#474)
f6a7329 
* Added world exporter

Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>

* Fixed CMake

Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>

* Changes based on review

Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>

* Added example world

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* bump required ign-common version

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* PR updates

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Update documentation to have simulation self terminate

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Rename world_export to collada_world_exporter

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Finish world exporter renaming

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Revert change

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added a tutorial

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Update transform

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added message

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added a test

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added more shapes

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Cleanup in two locations

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Fix build

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Apply scale, and fix codecheck

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
@caguero
Merge branch 'ign-gazebo4' into particle_system
9496d8f
@ahcorde @chapulina
Model creation tutorial using services (#530)
4c87e1d 
* Model creation tutorial using services

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated tutorial

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Tweaks to tutorial and example

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Move files

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* example only needs ign-transport

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@adlarkin
Fix topLevelModel method (#600)
d8b9d0c 
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin
add heat signature option to thermal system (#498)
b4e152d 
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@caguero
Merge branch 'ign-gazebo4' into particle_system
a02824c
@luca-della-vedova @mrushyendra @chapulina
Add service and GUI to configure physics parameters (step size and re…
9bc088d 
…al time factor) (#536)

Signed-off-by: Maganty Rushyendra <mrushyendra@yahoo.com.sg>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

Co-authored-by: mrushyendra <mrushyendra@yahoo.com.sg>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@j-rivero
👩‍🌾 Refactor UNIT_Server_TEST: move tests to integration (#594)
701b6ee 
Move several server interactions and fuel cached to their own
tests in integration.

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@chapulina
Also use Ignition GUI render event (#598)
4eda53f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
4 to 5
b8dab13 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Mar 1, 2021
@chapulina
Fix Windows compilation (#622))
30b6be3 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Mar 1, 2021
@chapulina
Fix Windows compilation (#622))
b0ff867 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Mar 1, 2021
@chapulina
Fix Windows compilation (#622)
38cfde6 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Mar 2, 2021
@chapulina
Fix Windows compilation (#622)
69ac140 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Mar 2, 2021
@chapulina
Fix Windows compilation (#622)
11c64f4 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Mar 2, 2021
@chapulina
Fix Windows compilation (#622)
c0f7566 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

FYI, I know there are new changes in ign-gazebo4 not included in this PR, but this is already big enough, those can come later. I'm now just fixing Windows compilation here. Homebrew CI has been broken all day so we can ignore that.

@adlarkin adlarkin force-pushed the chapulina/4_to_5 branch 2 times, most recently from 258a9d9 to f8fef92 Compare March 2, 2021 16:42
@chapulina @adlarkin
Fix Windows compilation (#622)
dc60a3a 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added needs upstream release Blocked by a release of an upstream library and removed needs upstream release Blocked by a release of an upstream library labels Mar 2, 2021
adlarkin
adlarkin reviewed Mar 3, 2021
View reviewed changes
Copy link
Contributor

@adlarkin adlarkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although Windows CI compiles now, there are quite a bit of new warnings: https://build.osrfoundation.org/job/ign_gazebo-pr-win/2331/msbuild/new/

These warnings didn't seem to appear when we originally got Windows CI to compile: https://build.osrfoundation.org/job/ign_gazebo-pr-win/2330/

It looks like a lot of the warnings are related to protobuf, so I am not sure how much we can do about those. I'm also not sure why there were no warnings on build 2330, but a lot warnings on build 2331. Would it at least be worth addressing the other warnings (for example, optical tactile plugin and tape measure plugin)?

@chapulina
Copy link
Contributor Author

I'm looking into Windows warnings, you're right that we should be warning-free.

@chapulina
Copy link
Contributor Author

Actually it looks like main already has lots of Windows warnings, so my suggestion is to merge this and address all warnings there at once. See the warning trends for the main branch:

https://build.osrfoundation.org/job/ign_gazebo-ci-win/

This was referenced Mar 3, 2021
Merged
Merged
@chapulina chapulina merged commit 6c91ff9 into main Mar 3, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch March 3, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig left review comments

@adlarkin adlarkin adlarkin approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.