Non-blocking paths request #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…ough even if asked too early Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #555 +/- ##
============================================
Coverage 77.51% 77.51%
============================================
Files 208 208
Lines 11526 11527 +1
============================================
+ Hits 8934 8935 +1
Misses 2592 2592
Continue to review full report at Codecov.
|
nkoenig
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by #550, even though it may not solve the underlying problem reported there.
Change the request for resource paths from the GUI to the server to be asynchronous so the GUI isn't blocked.
With this change, there's a chance that the GUI tries to load resources before it has all paths from the server. But considering that the request is done before other blocking or time consuming requests, like the world name and initial state, I think it would be hard for it not to be responded in time.
If you look at the commit history, I initially also added a button to the GUI that allowed the user to trigger a new request on demand. Then thinking about it, I removed the button because the original request should be fulfilled before that one anyway, so I don't think we'd have a problem of getting no response - we may get a delayed response and the button doesn't change that.
If we want to be very thorough, maybe a button that tries to reload all resources again would be more useful, because we may get new paths added later. But such a button would be non-trivial to implement, so I'll just abandon this idea until we have a strong use case.