Added missing version namespace

[nkoenig]

Adding this to help fix downstream users of ign-gazebo, such as ign-launch.

Signed-off-by: Nate Koenig nate@openrobotics.org

[codecov]

Codecov Report

Merging #541 (f75efff) into ign-gazebo3 (6b6f76f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo3     #541   +/-   ##
============================================
  Coverage        77.61%   77.61%           
============================================
  Files              208      208           
  Lines            11526    11526           
============================================
  Hits              8946     8946           
  Misses            2580     2580           

Impacted Files	Coverage Δ
...e/ignition/gazebo/detail/EntityComponentManager.hh	95.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6f76f...f75efff. Read the comment docs.

[j-rivero]

That one was an interesting change. inline namespaces are specially designed to modify the binary symbols names so changing it in a released branch should ring the alarms. However, the abichecker is happy with it. In fact looking for some code modified here does not appear anywhere in binaries:

/usr/lib/x86_64-linux-gnu🔒 ❯ nm -D --demangle  libignition-gazebo3-* | grep EntityComponentManager | grep First
/usr/lib/x86_64-linux-gnu🔒 ❯ 

My hypothesis is that the file belongs to a private part (details) and that makes the real work of being private and not exposed to public ABI. I might be wrong and the abichecker could also be wrong and weird problems might appear somehow in the new release. Keep an eye on these change if that happen.