3 to 4 #459
Merged
3 to 4 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Also use unordered types. Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…ed (#454) The segfault occurs when a model containing a Breadcrumbs system gets unloaded by the level manager. Since systems don't get unloaded, the Breadcrumbs system continues to operate assuming that the model it is associated with is valid. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #459 +/- ##
============================================
Coverage 77.26% 77.27%
============================================
Files 208 208
Lines 11192 11192
============================================
+ Hits 8648 8649 +1
+ Misses 2544 2543 -1
Continue to review full report at Codecov.
|
Closed
chapulina
reviewed
Nov 13, 2020
There was a problem hiding this comment.
Just a minor comment. Since ign-rendering 4.1.0 is out, and this PR depends on it (see conversation on #441 ), do you mind bumping the version requirement here:
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
chapulina
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port
ign-gazebo3toign-gazebo4.One thing to note about this forward port is that
examples/worlds/log_playback.sdfexists inign-gazebo3, but notign-gazebo4. #386 details why this file was removed. Also, is theexamples/worlds/log_playback.sdffile inign-gazebo3correct, or does that also need to be updated?