Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added user commands to example thermal camera world #442

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Added user commands to example thermal camera world #442

merged 1 commit into from
Nov 13, 2020

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Nov 3, 2020 •
edited
Loading

@adlarkin adlarkin requested review from nkoenig and iche033 November 3, 2020 20:21
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020 •
edited
Loading

Codecov Report

Merging #442 (c5994b2) into ign-gazebo3 (fb5c2d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3     #442   +/-   ##
============================================
  Coverage        77.31%   77.31%           
============================================
  Files              205      205           
  Lines            11018    11018           
============================================
  Hits              8519     8519           
  Misses            2499     2499

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5c2d3...990e4f2. Read the comment docs.

@adlarkin adlarkin changed the title Adlarkin/thermal camera tutorial Thermal camera tutorial Nov 3, 2020
iche033
iche033 reviewed Nov 3, 2020
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take a look at this comment for including images using @image

I think a section on interpreting thermal camera data would be useful, i.e. the info here. This lets users know how to convert the raw unsigned int 16 bit image data back to to Kelvin

@adlarkin adlarkin force-pushed the adlarkin/thermal_camera_tutorial branch from c3391b1 to 1694fb7 Compare November 5, 2020 21:02
@adlarkin adlarkin requested a review from iche033 November 5, 2020 21:36
iche033
iche033 reviewed Nov 5, 2020
View reviewed changes
@adlarkin adlarkin force-pushed the adlarkin/thermal_camera_tutorial branch from 91bf4b6 to 1cd36a6 Compare November 6, 2020 14:23
@adlarkin adlarkin requested a review from iche033 November 6, 2020 14:23
@adlarkin adlarkin mentioned this pull request Nov 9, 2020
Merged
@adlarkin
Copy link
Contributor Author

adlarkin commented Nov 9, 2020

The tutorial has been moved over to gazebosim/gz-sensors#61 in ac386d8. We still need this PR because it adds the user commands plugin to the example SDF world.

@adlarkin adlarkin changed the title Thermal camera tutorial Added user commands to example thermal camera world Nov 12, 2020
@adlarkin adlarkin force-pushed the adlarkin/thermal_camera_tutorial branch 2 times, most recently from c5994b2 to 3d05bbf Compare November 13, 2020 00:17
@adlarkin
Added user commands to example thermal camera world (#442)
990e4f2 
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin adlarkin force-pushed the adlarkin/thermal_camera_tutorial branch from 3d05bbf to 990e4f2 Compare November 13, 2020 01:16
@adlarkin adlarkin merged commit 990e4f2 into ign-gazebo3 Nov 13, 2020
@adlarkin adlarkin deleted the adlarkin/thermal_camera_tutorial branch November 13, 2020 01:45
doisyg pushed a commit to wyca-robotics/ign-gazebo that referenced this pull request Dec 13, 2020
@adlarkin
Added user commands to example thermal camera world (gazebosim#442)
a2077a7 
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Guillaume Doisy <guillaume.doisy@wyca.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

@chapulina chapulina Awaiting requested review from chapulina

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

@iche033 iche033 Awaiting requested review from iche033

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adlarkin @nkoenig @iche033