-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a crash in the grid_config plugin #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org>
chapulina
added a commit
that referenced
this pull request
Oct 14, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
See #413 |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #412 +/- ##
================================================
+ Coverage 65.71% 77.30% +11.59%
================================================
Files 127 205 +78
Lines 6238 11018 +4780
================================================
+ Hits 4099 8518 +4419
- Misses 2139 2500 +361
Continue to review full report at Codecov.
|
chapulina
approved these changes
Oct 21, 2020
mjcarroll
pushed a commit
that referenced
this pull request
Oct 21, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
doisyg
pushed a commit
to wyca-robotics/ign-gazebo
that referenced
this pull request
Dec 13, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Guillaume Doisy <guillaume.doisy@wyca.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grid plugin will crash when changing properties if a world has
<grid>false</grid>
in the<scene>
tag.For example:
This fixes the problem, but there might be a more elegant solution.