Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 ➡️ 5 #1186

Merged
merged 13 commits into from
Nov 10, 2021
Merged

4 ➡️ 5 #1186

merged 13 commits into from
Nov 10, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo4 to ign-gazebo5

Branch comparison: ign-gazebo5...gazebo4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 12 commits October 27, 2021 11:42
@chapulina
Fix integers and floats on component inspector (#1143)
3443ad4 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@adlarkin
use uint64_t for ComponentInspector Entity IDs (#1144)
63decda 
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@nkoenig
Support setting the background color for sensors (#1147)
6322451 
* Support setting the background color for sensors

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added ambient light

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
@jennuine
Edit material colors in component inspector (#1123)
1f44a05 
* edit colors in comp insp

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* added missing files

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* added //material to inserted shapes

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* remove plot icons

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* updated gui design

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* reviewer feedback

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* fix precision loss

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@peci1
Backport gazebo::Util::validTopic() from ign-gazebo4. (#1153)
9cafc6b 
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@peci1
Fix generation of systems library symlinks in build directory (#1160)
a76cea4 
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@ahcorde
Fixed sensor plugins (#1104)
c0ad543 
* Fixed sensor plugins

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed compilation

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fix comment

Signed-off-by: ahcorde <ahcorde@gmail.com>
@adlarkin
[backport #1131] fix updating a component's data via SerializedState …
df06bb2 
…msg (#1149)

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@chapulina
3 ➡️ 4
994c807 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Fix updating component from state (#1181)
546c95f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
3 ➡️ 4 (#1181)
11254b3 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
4 ➡️ 5
8c91071 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from iche033 as a code owner November 10, 2021 18:08
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Nov 10, 2021
@chapulina
Add <material> to capsule and ellipsoid (#1186)
9f1124f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #1186 (9f1124f) into ign-gazebo5 (01a27f9) will decrease coverage by 0.69%.
The diff coverage is 31.29%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo5    #1186      +/-   ##
===============================================
- Coverage        66.38%   65.69%   -0.70%     
===============================================
  Files              248      249       +1     
  Lines            19033    19322     +289     
===============================================
+ Hits             12635    12693      +58     
- Misses            6398     6629     +231
Impacted Files Coverage Δ
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
include/ignition/gazebo/rendering/RenderUtil.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.hh 28.57% <ø> (ø)
src/gui/plugins/shapes/Shapes.cc 22.72% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 4.63% <1.58%> (-1.04%) ⬇️
src/systems/user_commands/UserCommands.cc 51.50% <4.41%> (-6.45%) ⬇️
src/rendering/RenderUtil.cc 44.70% <21.87%> (-1.69%) ⬇️
src/systems/sensors/Sensors.cc 73.93% <50.00%> (-0.95%) ⬇️
src/EntityComponentManager.cc 90.63% <66.66%> (+3.65%) ⬆️
src/systems/logical_camera/LogicalCamera.cc 76.25% <77.77%> (-1.84%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a27f9...9f1124f. Read the comment docs.

@chapulina chapulina merged commit 2278a03 into ign-gazebo5 Nov 10, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch November 10, 2021 22:49
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
@chapulina @WilliamLewww
Add <material> to capsule and ellipsoid (gazebosim#1186)
b8943b7 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chapulina @nkoenig @adlarkin @jennuine @peci1 @ahcorde