Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of systems library symlinks in build directory #1160

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Nov 2, 2021

🦟 Bug fix

Fixes #1152

Summary

As discussed in #1152, the unversioned library symlinks for systems are generated into the root of the build directory, but tests expect them in the lib subdirectory of the build directory. This PR fixes the location.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
peci1 added 2 commits November 2, 2021 22:33
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1160 (6237a2b) into ign-gazebo3 (9cafc6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3    #1160   +/-   ##
============================================
  Coverage        77.47%   77.47%           
============================================
  Files              222      222           
  Lines            12769    12769           
============================================
  Hits              9893     9893           
  Misses            2876     2876           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cafc6b...6237a2b. Read the comment docs.

@peci1
Copy link
Contributor Author

peci1 commented Nov 2, 2021

CI is green except Mac OS. The failures seem unrelated to me.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I verified locally that the build folder is fixed and the install folder remains the same.

@chapulina chapulina merged commit a76cea4 into gazebosim:ign-gazebo3 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants