Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 ➡️ 4 #1181

Merged
merged 9 commits into from
Nov 10, 2021
Merged

3 ➡️ 4 #1181

merged 9 commits into from
Nov 10, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo3 to ign-gazebo4

Branch comparison: ign-gazebo4...ign-gazebo3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 8 commits October 27, 2021 11:42
@chapulina
Fix integers and floats on component inspector (#1143)
3443ad4 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@adlarkin
use uint64_t for ComponentInspector Entity IDs (#1144)
63decda 
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@nkoenig
Support setting the background color for sensors (#1147)
6322451 
* Support setting the background color for sensors

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added ambient light

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
@peci1
Backport gazebo::Util::validTopic() from ign-gazebo4. (#1153)
9cafc6b 
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@peci1
Fix generation of systems library symlinks in build directory (#1160)
a76cea4 
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@ahcorde
Fixed sensor plugins (#1104)
c0ad543 
* Fixed sensor plugins

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed compilation

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fix comment

Signed-off-by: ahcorde <ahcorde@gmail.com>
@adlarkin
[backport #1131] fix updating a component's data via SerializedState …
df06bb2 
…msg (#1149)

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@chapulina
3 ➡️ 4
994c807 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from iche033 as a code owner November 9, 2021 21:57
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Nov 9, 2021
@chapulina
Copy link
Contributor Author

@adlarkin , mind checking if I handled #1149 correctly? Thanks!

@chapulina
Fix updating component from state (#1181)
546c95f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
adlarkin
adlarkin approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the forward port!

@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #1181 (546c95f) into ign-gazebo4 (1f44a05) will decrease coverage by 0.05%.
The diff coverage is 59.04%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4    #1181      +/-   ##
===============================================
- Coverage        66.32%   66.26%   -0.06%     
===============================================
  Files              245      245              
  Lines            18468    18552      +84     
===============================================
+ Hits             12248    12294      +46     
- Misses            6220     6258      +38
Impacted Files Coverage Δ
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
include/ignition/gazebo/rendering/RenderUtil.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.hh 28.57% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 4.85% <4.54%> (-0.21%) ⬇️
src/systems/sensors/Sensors.cc 73.93% <50.00%> (-0.95%) ⬇️
src/rendering/RenderUtil.cc 46.66% <60.00%> (-0.09%) ⬇️
src/EntityComponentManager.cc 90.70% <66.66%> (+3.62%) ⬆️
src/systems/logical_camera/LogicalCamera.cc 76.25% <77.77%> (-1.84%) ⬇️
src/systems/air_pressure/AirPressure.cc 73.97% <79.31%> (-1.79%) ⬇️
src/systems/altimeter/Altimeter.cc 74.66% <80.00%> (-1.81%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f44a05...546c95f. Read the comment docs.

@chapulina chapulina merged commit 11254b3 into ign-gazebo4 Nov 10, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch November 10, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlarkin adlarkin adlarkin approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chapulina @adlarkin @nkoenig @peci1 @ahcorde