Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Add quality and filters close #219 #656

Closed
wants to merge 1 commit into from

Conversation

david4096
Copy link
Member

@david4096 david4096 commented Jul 8, 2016

Updates the work presented by @heuermh in #304 and @johntbates in #220 to protobuf. Includes the filters_passed field as suggested by @fnothaft

Closes #219

@david4096
Copy link
Member Author

Bump, this will close a couple of open PRs that fulfill the same functionality.

@kozbo
Copy link
Contributor

kozbo commented Aug 3, 2016

+1

@heuermh
Copy link
Contributor

heuermh commented Jan 12, 2017

-0

We decided to go a different way in bdg-formats, in avro schema

  /**
   True if filters were applied for this variant. VCF column 7 "FILTER" any value other
   than the missing value.
   */
  union { null, boolean } filtersApplied = null;

  /**
   True if all filters for this variant passed. VCF column 7 "FILTER" value PASS.
   */
  union { null, boolean } filtersPassed = null;

  /**
   Zero or more filters that failed for this variant. VCF column 7 "FILTER" shared across
   all alleles in the same VCF record.
   */
  array<string> filtersFailed = [];

@david4096
Copy link
Member Author

Closing in favor of #777

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants