Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

GAVariant missing "quality" and "filter" #219

Closed
jrobinso opened this issue Jan 12, 2015 · 5 comments
Closed

GAVariant missing "quality" and "filter" #219

jrobinso opened this issue Jan 12, 2015 · 5 comments
Assignees

Comments

@jrobinso
Copy link

Hi, the v0.5.1 GAVariant specification does not list the "filter" and "quality" fields, which are part of the VCF specification. However, variants I fetch from https://www.googleapis.com/genomics/v1beta2/variants/search do include them. Is this a mistake in the specification, or are these fields no longer required?

@johntbates
Copy link

Hi, Jim.

You're correct: the GAVariant schema lacks those fields, despite the fact that the Google v1beta2 implementation returns them. This appears to be an oversight in the specification and I'll be submitting a pull request to address this. Thank you for pointing it out!

-John Bates

@skeenan
Copy link
Member

skeenan commented Apr 10, 2015

This has been dormant since January. Closing in 2 days.

@jeromekelleher
Copy link
Contributor

There is still a PR open (#220) for this, so I don't think we should close it. Perhaps we should ping those involved and try to get the PR updated?

@skeenan
Copy link
Member

skeenan commented Apr 10, 2015

Thanks @jeromekelleher I've pinged @johntbates in #220

heuermh added a commit to heuermh/ga4gh-schemas that referenced this issue May 9, 2015
heuermh added a commit to heuermh/ga4gh-schemas that referenced this issue May 9, 2015
heuermh added a commit to heuermh/ga4gh-schemas that referenced this issue Dec 15, 2015
heuermh added a commit to heuermh/ga4gh-schemas that referenced this issue Dec 15, 2015
david4096 added a commit to david4096/ga4gh-schemas that referenced this issue Jul 8, 2016
david4096 added a commit to david4096/ga4gh-schemas that referenced this issue Jul 8, 2016
david4096 added a commit to david4096/ga4gh-schemas that referenced this issue Jul 8, 2016
david4096 added a commit to david4096/ga4gh-schemas that referenced this issue Jul 8, 2016
@david4096
Copy link
Member

Closed with #826

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants