This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Adding quality, filtersFailed, and filtersPassed to Variant, fixes #219 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want our filters to just be strings, or do we want some complicated ontology of filter types and their parameters? I think strings like we have is probably the right way to do it for the moment. So I will +1 this. |
e5f7abf to
e48199c
Compare
e48199c to
5beeb21
Compare
|
Sorry for the noise, rebased and squashed second commit to fix non-ascii doc characters. |
|
Please see #656 to close this |
|
Closing in favor of #656 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using changes proposed by @johntbates in pull request #220 and @fnothaft in comment
#220 (comment)