forked from microsoft/winget-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency graph #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
Jul 12, 2021
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
|
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
|
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
|
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
|
… of managing package dep
* specs for show dependencies * microsoft#163 - Dependencies with relative paths Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * Typos in show dependencies spec file Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * change pattern for SHA256 and add new words to expect * change import output, show all dependencies together * validate will show dependencies * change multiple dependencies from oneline to nested one line each * uninstall will not be covered in this iteration, adding some details about dependencies declaration on manifest * spellcheck Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* first tests for show depenencies feature * show dependencies feature for show, install, need to change message * showflow output changed * install commands shows dependencies as in specs * tests for informing dependencies on commands: show, install, upgrade, import * refactor install flow * change import command from install flow (install multiple) * import shows all dependencies together * show dependencies for validate and uninstall * tests for validate and uninstall * create show dependencies exp feature * test for validate command * put functionality under experimental feature check * enable show dep experimental feature on unit test cases * change experimental feature name * remove info stream characters on testcase * move check for exp feature inside report function, create new DependenciesFlow * DependenciesFlow header and cpp inside Workflow * �change representation of Dependency, create DependencyType and DependencyList; add Dependency to context data * dependencies context data is of type DependencyList (not optional) * fix spelling errors * ApplyTo function, can receibe a lambda function to apply on specific DpeendencyType * localize user strings, code style changes, validate report dependencies task divided, creates ValidateFlow * change uninstall flow (gets dependencies from package version), make DependencyList.dependencies private, code style * add missing report dep on upgrade * Update src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw Co-authored-by: JohnMcPMS <johnmcp@microsoft.com> * compare id with ICU case insensitive * move dependencies related functions to DependenciesFlow, ReportDependencies is now a WorkflowTask receiving resource string id * TODO to get dependencies on uninstall context, remove testcase for now, move dependency related function to DependenciesFlow * wfIds not temporary * DependencyList Add function checks for existence and updates min version if needed * root dependencies are used when installer are not present, otherwise installer are preferred * merge commits from master * style and details * fix merge conflicts * spellcheck exception * detail when adding dep * divide identity report and installation disclaimer from actual installation Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>
JohnMcPMS
pushed a commit
that referenced
this pull request
Oct 6, 2021
* Remove old Manifest schema spec * Update index.md * Remove old reference to preview-note * Update validate.md * Delete upgrade.png * Update upgrade.md * Update uninstall.md * Add files via upload * Add files via upload * Add files via upload * Update source.md * Delete source.png * Add files via upload * Delete source.png * Add files via upload * Update show.md * Update settings.md * Update search.md * Update list.md * Update install.md * Update index.md * Update help.md * Images #1 * Create source.png * Update list.md * Update features.md * Update export.md * images microsoft#2 * Create hash.png * Update hash.md * Update import.md * Images microsoft#3 * Update Labels * Update repository.md * Update manifest.md * Update index.md * docs upgrade/uninstall * images added * Update uninstall-multiple.png * Update repository.md * Update manifest.md * Update validate.md * Update upgrade.md * Update uninstall.md * Update validate.md * Update upgrade.md * Update source.md * Update show.md * Update settings.md * Update search.md * Update list.md * Update install.md * Delete help.png * Add files via upload * Update index.md * Update index.md * Update import.md * Update hash.md * Update upgrade.md * Update uninstall.md * Update list.md * Update export.md * final commit * Update patterns.txt * Update expect.txt * Update ManifestSpecv1.0.md * Update manifest.md * Update manifest.md * allow words * @jedieaston's suggestion * expect.txt alphabetical order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto