Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget Package Dependencies #1552

Closed

Conversation

hackean-msft
Copy link
Contributor

@hackean-msft hackean-msft commented Oct 5, 2021

This pull request

  • builds dependency graph
  • Detect loops in the graph and reports it.
  • install dependencies based on the order generated by the graph.

This change is based on fzanollo#1

TODO:
Create persistent dependency graph for the entire winget repository to be used for dependencies validation.
Create a winget util interface for communcating with this graph.

Microsoft Reviewers: Open in CodeFlow

fzanollo and others added 30 commits June 4, 2021 18:16
…DependencyList.dependencies private, code style
Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>
…encies is now a WorkflowTask receiving resource string id
…w, move dependency related function to DependenciesFlow
@hackean-msft hackean-msft requested a review from a team as a code owner October 5, 2021 17:24
@hackean-msft hackean-msft changed the title Build Dependency Graph Winget Package Dependencies Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

@check-spelling-bot Report

Unrecognized words, please review:

  • suitagle
Previously acknowledged words that are now absent ATL Bluetooth contosa contosainstaller convertto doctordns DSL etail globals IInstalled Jaifroid JDKs mikefrobbins mytool Nieto powershellexplained xbox
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:hackean-msft/winget-cli.git repository
on the user/flopyy/dependencyGraph branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/934612281" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

@hackean-msft
Copy link
Contributor Author

Closed this pull request, contributing directly to #1340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants