Add taxonomy #408
Merged
Add taxonomy #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove .DS_Store
Issue #6 - Remove generated doc from repository.
Introducing values
For a first version, let's do without subnodes. We can always add them later if we find out that they are needed.
… to make them future-proof. In the original version, requests were implemented as a `struct` with `pub` fields. That's going to cause code breakage if we decide to add or rework fields in the future (e.g. to restore subnodes). This patch replaces the public fields with a proper API that may be used to create and combine requests.
Better deserialization error messages
Implementing Parse::from_str_at
Add WebPushNotify type for webpush adapter
Better deserialization error messages
…of 'typ' - matching the deserialization format.
When serialized, extension now sends 'type' instead of 'typ' - matchi…
Adding ChannelKind::ExecuteEveryInterval, ExecuteAfterDelay
Switching Color from RGBA to HSV
* Tags persistence
|
Local compilation: https://travis-ci.org/fxbox/foxbox/jobs/124767230#L824 r? @Yoric |
|
What will happen to Taxonomy's WIP branches (e.g. fxbox/deprecated-taxonomy#104 ) when we merge this? |
|
We'll need to migrate them manually. @JohanLorenzo has promised to help :) |
|
Yes, we'll have to manually create the new branches/PRs. A couple of ways I see:
|
| @@ -0,0 +1,2 @@ | |||
| target/ | |||
There was a problem hiding this comment.
I haven't paid attention for other repos, but is this file necessary?
There was a problem hiding this comment.
Good catch. That particular file is not necessary as .gitignore at the root of the repo already takes care of target/ and Cargo.lock. I added an extra commit to clean it up
|
r=me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.