Improve global state management and concurrency (Context, Controller). #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves and simplifies the way we manage global state, in collaboration with @jedireza.
With this commit:
Controller
coordinates the interaction of services, servers, and events.ContextTrait
has been merged intoController
;FoxBox
is the concrete implementation ofController
.(Why the name change? In practice,
Context
was acting more like a controller than a context; as wasController
. The termController
is more precise.)We no longer coarsely lock the global state. Previously, we passed around
Arc<Mutex<Context>>
everywhere (aliased asSharedContext
). When we needed to access the global context, we would coarselylock()
the mutex. This is inefficient and cumbersome. Instead, we only lock what we need to.This allows us to clone and share references to a generic
Controller
(i.e.<T: Controller>
) safely and concurrently.NOTE: Git did not detect the rename of
context.rs
tocontroller.rs
; the diff is slightly misleading in that regard. I'd recommend using the split view for easier reading.