Move iron-test out of regular build. r=jlorenzo #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // When this comment was written, putting these 2 lines in before_each returns a compile error: | ||
| // ``` error: unresolved import `self::iron_test::request`. Could not find `iron_test` in | ||
| // service_router::service_router` [E0432] ``` | ||
| extern crate iron_test; |
There was a problem hiding this comment.
Nice! Thanks for finding how to fix it.
For reference, @ferjm gave me the trick on IRC: you have to do the import in main.rs
|
r+ Looks good to me overall, modulo a few nits and a small improvement we could do. |
da83d86 to
8682a77
Compare
ferjm
added a commit
that referenced
this pull request
Mar 1, 2016
Move iron-test out of regular build. r=jlorenzo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.