-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode decorator for the dynamic task #2994
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
from flytekit.core.python_auto_container import default_task_resolver | ||
|
||
return CompilationState(prefix=prefix, task_resolver=default_task_resolver) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this if the correct task resolver is being set in compile
in flytekit/core/workflow.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set the task resolver in the ctx.with_compilation_state(...)
, but there are some places where new_compilation_state()
get called, potentially causing the loss of the resolver if it's not set.
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
* vscode decorator for the dynamic task (#2994) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use correct name in flyteagent test (#3011) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * fix: Improve error details and logging config handling (#3012) Signed-off-by: Kevin Su <pingsutw@apache.org> * Add python interpreter into vscode settings (#3014) Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * add support for toggling data mode for array node (#2940) * add support for toggling data mode for array node Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * clean up Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * clean up Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * cleanup Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * Bump flyteidl lower-bound to 1.14.1 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add import of FlyteLaunchPlan back Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Store protos in local cache (#3022) * Store proto obj instead of model Literal in local cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove unused file Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Paul Dittamo <37558497+pvditt@users.noreply.github.com>
Tracking issue
NA
Why are the changes needed?
To support
vscode
decorator for the dynamic tasks.What changes were proposed in this pull request?
Set the correct resolver in the current context, so flytekit can compile the vscode task
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link