Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode decorator for the dynamic task #2994

Merged
merged 38 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
Signed-off-by: Kevin Su <pingsutw@apache.org>
  • Loading branch information
pingsutw committed Dec 3, 2024
commit 935be5c28dccbf860f7188357edc3bba9c7c70f1
2 changes: 0 additions & 2 deletions flytekit/core/base_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -751,8 +751,6 @@ def dispatch_execute(
logger.info(f"Invoking {self.name} with inputs: {native_inputs}")
with timeit("Execute user level code"):
try:
if hasattr(self, "run"):
self.run() # it will start vscode server
native_outputs = self.execute(**native_inputs)
except Exception as e:
if is_local_execution:
Expand Down
2 changes: 1 addition & 1 deletion flytekit/interactive/vscode_lib/decorator.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ def __init__(
config=config,
)

def run(self, *args, **kwargs):
def execute(self, *args, **kwargs):
ctx = FlyteContextManager.current_context()
logger = flytekit.current_context().logging
ctx.user_space_params.builder().add_attr(
Expand Down