add support for toggling data mode for array node #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
…asks Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
approved these changes
Dec 23, 2024
eapolinario
added a commit
that referenced
this pull request
Dec 23, 2024
* add support for toggling data mode for array node Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * clean up Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * clean up Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * cleanup Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * Bump flyteidl lower-bound to 1.14.1 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add import of FlyteLaunchPlan back Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
added a commit
that referenced
this pull request
Dec 26, 2024
* vscode decorator for the dynamic task (#2994) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use correct name in flyteagent test (#3011) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * fix: Improve error details and logging config handling (#3012) Signed-off-by: Kevin Su <pingsutw@apache.org> * Add python interpreter into vscode settings (#3014) Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * add support for toggling data mode for array node (#2940) * add support for toggling data mode for array node Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * clean up Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * clean up Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * cleanup Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * Bump flyteidl lower-bound to 1.14.1 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add import of FlyteLaunchPlan back Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Store protos in local cache (#3022) * Store proto obj instead of model Literal in local cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove unused file Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Paul Dittamo <37558497+pvditt@users.noreply.github.com>
shuyingliang
pushed a commit
to shuyingliang/flytekit
that referenced
this pull request
Jan 11, 2025
* add support for toggling data mode for array node Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * clean up Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * clean up Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * cleanup Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * Bump flyteidl lower-bound to 1.14.1 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add import of FlyteLaunchPlan back Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Shuying Liang <shuying.liang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes: https://linear.app/unionai/issue/DX-528/[bug]-reference-tasks-cannot-be-mapped-over
need to upstream some ArrayNode changes to support mapping over reference tasks: flyteorg/flyte#3573
What changes were proposed in this pull request?
Toggle DataMode for ArrayNode to support creating individual files for subNodes.
(need to upstream changes, plus looking into adding an additional data mode to read a single file but from an offset of bytes for each index)
How was this patch tested?
Sandbox + dogfood
Setup process
Screenshots
Check all the applicable boxes
Related PRs
need flyteorg/flyte#6074 merged + flyteidl bump
Docs link