pre-release stabilization #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PULL_REQUEST_TEMPLATE.md
release/1.0 to main update
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…-redirects-1.15.4 Bump follow-redirects from 1.15.3 to 1.15.4
…om webpack callback from downstream.
…file checksum results
* release/1.0: update tsconfig.json add index.web.tsx file fix webpack resolve.alias
|
first time after |
|
And when running second time after that cancelled error, bundle install is still trigered |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
@pauliusguzas this is expected outcome. lockfile only gets generated after install is complete |
* fix/withRNVRNConfig: disable react-native-permissions for tvos fix/withRNVRNConfig
pauliusguzas
requested changes
Jan 26, 2024
There was a problem hiding this comment.
npx rnv target launch -p ios passes when sim isn't open but also doesn't open any sim
npx rnv target launch -p ios fails on both harness and template when sim is already open
pauliusguzas@MBP-de-Flexn app-harness % npx rnv target launch -p ios
┌──────────────────────────────────────────────────────────────────────────────┐
│ │
│ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │
│ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │
│ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │
│ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │
│ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │
│ │
│ Version: 1.0.0-rc.9 │
│ https://renative.org │
│ 🚀 Firing up!... │
│ $ npx rnv target launch -p ios │
│ Start Time: 1/26/2024, 5:02:55 PM │
│ │
└──────────────────────────────────────────────────────────────────────────────┘
[ task ] registerEngine:engine-core[1]
[ task ] configureRuntimeDefaults[1] appId:undefined
[ task ] checkAndMigrateProject[1]
[ task ] loadPluginTemplates[1]
[ task ] parseRenativeConfigs[1]
[ task ] getWorkspaceDirPath[1]
[ task ] generatePlatformTemplatePaths[1]
[ task ] checkAndBootstrapIfRequired[1]
[ task ] loadIntegrations[1]
[ task ] loadEngines[1]
[ task ] loadEnginePluginDeps[1]
[ task ] loadEnginePackageDeps[1]
[ task ] registerEngine:engine-rn[1]
[ task ] findSuitableTask[1]
[ info ] Current Engine: engine-core path: /Users/pauliusguzas/Desktop/renative/renative/packages/engine-core/lib
[ task ] registerMissingPlatformEngines[1]
[ task ] initializeTask[1] target launch
[ task ] => [target launch]
[ task ] [target launch] taskRnvTargetLaunch[1]
[ task ] [target launch] isPlatformSupported[1]
[ task ] [target launch] checkAndConfigureSdks[1]
[ task ] => [target launch] => [workspace configure]
[ task ] [workspace configure] taskRnvWorkspaceConfigure[1]
[ task ] <= [target launch] <= workspace configure
[ task ] [target launch] checkSdk[1]
[ task ] [target launch] launchAppleSimulator[1] iPhone 14
[ task ] [target launch] getAppleDevices[1] ignoreDevices:true ignoreSimulators:undefined
✔ Executing: xcrun simctl list --json
[ info ] [target launch] Launching: iPhone 14 (use -t to use different target)...
┌──────────────────────────────────────────────────────────────────────────────┐
│ 🚀 SUMMARY | 1/26/2024, 5:02:56 PM │
│ $ npx rnv target launch -p ios │
├──────────────────────────────────────────────────────────────────────────────┤
│ ReNative Version: 1.0.0-rc.9 │
│ Project Name ($package.name): @rnv/app-harness │
│ Project Version ($package.version): 1.0.0-rc.9 │
│ Workspace ($.workspaceID): rnv │
│ Platform (-p): ios │
│ Engine ($.platforms.ios.engine): engine-core │
│ App Config (-c): harness │
│ Build Scheme (-s): debug │
│ Env Info: darwin | x64 | node v18.17.0 │
│ Executed Time: 0h:0m:1s:467ms │
│ │
│ [ error ] [target launch] COMMAND:
xcrun simctl boot 6F0CD255-F21F-4B8F-B6BB-384E3B04C665
FAILED with ERROR:
Command failed with exit code 149: xcrun simctl boot 6F0CD255-F21F-4B8F-B6BB-384E3B04C665
Error: Command failed with exit code 149: xcrun simctl boot 6F0CD255-F21F-4B8F-B6BB-384E3B04C665
at makeError (/Users/pauliusguzas/Desktop/renative/renative/node_modules/execa/lib/error.js:60:11)
at handlePromise (/Users/pauliusguzas/Desktop/renative/renative/node_modules/execa/index.js:118:26)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
│ │
└──────────────────────────────────────────────────────────────────────────────┘
pauliusguzas@MBP-de-Flexn app-harness %
times for running:
Executed Time: 0h:9m:54s:842ms - harness ios
Executed Time: 0h:6m:26s:67ms - harness tvos
Executed Time: 0h:9m:53s:727ms - template ios
Executed Time: 0h:5m:34s:923ms - template tvos
run time issue seems to be fixed
|
|
…pack-config fix. Improve webpack callback chaining in withRNVNext to execute cust…
* release/1.0: (138 commits) update tsconfig.json add index.web.tsx file fix webpack resolve.alias fix target in Summary fix java injections install pkg-dir@7.0.0 before first run conditionally add args add whitespace between cmd and args, fix args removal for some commands increase the number of attempts to run the bundler formatted and added a small fix 1.0.0-rc.9 chore: add commented injection for testing fix: added semver to compare versions added testcase, fixed logic added testcases don't expect integers for ios versionCode fix: small bugs feat: added warnings add plugin injections add android.os.Bundle as injections ... # Conflicts: # yarn.lock
* main: fix. Fix typo of parameter for webpack callback. fix. Improve webpack callback chaining in withRNVNext to execute custom webpack callback from downstream. Bump follow-redirects from 1.15.3 to 1.15.4 Update PULL_REQUEST_TEMPLATE.md # Conflicts: # yarn.lock
This was referenced Jan 29, 2024
pauliusguzas
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
rnv target launch -p iosdoes not workpod --versionchecksnpx rnvwithout arguments should show all available optionsRelated issues
Npm releases
n/a