Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix. Improve webpack callback chaining in withRNVNext to execute cust… #1363

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix. Improve webpack callback chaining in withRNVNext to execute cust… #1363

merged 2 commits into from
Jan 29, 2024

Conversation

magician-margatroid
Copy link
Contributor

@magician-margatroid magician-margatroid commented Jan 25, 2024 •
edited
Loading

…om webpack callback from downstream.

Description

  • This PR introduces chaining for webpack callback if custom webpack config callback was defined in downstream by user (e.g., next.config.js). (Thx for the debugging guidance from Jacko.)
  • Verified with apps generated by @rnv/template-starter.
  • yarn sanity passed.

Related issues

Npm releases

n/a

@pavjacko pavjacko added this to the 1.0 milestone Jan 26, 2024
@pavjacko pavjacko merged commit 3d3fb9b into flexn-io:main Jan 29, 2024
@pavjacko pavjacko mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pavjacko pavjacko

@ElenaDiachenko ElenaDiachenko

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@magician-margatroid @pavjacko @ElenaDiachenko