pre-release stabilization

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,81 +1,11 @@
 ## Description
 
--   Describe the nature of the work / fix
+- Small description
 
-## Breaking Changes
+## Related issues
 
--   PRs should not introduce breaking changes to existing functionality
--   if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
-    -   `0.x.0` Add new functionality + add `DEPRECATED` warning to existing fuctionality
-    -   `0.[x+1].0` Remove deprecated functionality
+- GH issues
 
-## I have tested my changes on:
+## Npm releases
 
-ReNative project directly:
-
--   [ ] ios simulator
--   [ ] ios device
--   [ ] android simulator
--   [ ] android device
--   [ ] web browser
--   [ ] tvos simulator
--   [ ] tvos device
--   [ ] androidtv simulator
--   [ ] androidtv device
--   [ ] androidwear simulator
--   [ ] androidwear device
--   [ ] tizen simulator
--   [ ] tizen device
--   [ ] tizenmobile simulator
--   [ ] tizenwatch device
--   [ ] webos simulator
--   [ ] webos device
--   [ ] macos
--   [ ] windows
--   [ ] chromecast device
-
-New project:
-
--   [ ] ios simulator
--   [ ] ios device
--   [ ] android simulator
--   [ ] android device
--   [ ] web browser
--   [ ] tvos simulator
--   [ ] tvos device
--   [ ] androidtv simulator
--   [ ] androidtv device
--   [ ] androidwear simulator
--   [ ] androidwear device
--   [ ] tizen simulator
--   [ ] tizen device
--   [ ] tizenmobile simulator
--   [ ] tizenwatch device
--   [ ] webos simulator
--   [ ] webos device
--   [ ] macos
--   [ ] windows
--   [ ] chromecast device
-
-Existing Project created with previous version of renative:
-
--   [ ] ios simulator
--   [ ] ios device
--   [ ] android simulator
--   [ ] android device
--   [ ] web browser
--   [ ] tvos simulator
--   [ ] tvos device
--   [ ] androidtv simulator
--   [ ] androidtv device
--   [ ] androidwear simulator
--   [ ] androidwear device
--   [ ] tizen simulator
--   [ ] tizen device
--   [ ] tizenmobile simulator
--   [ ] tizenwatch device
--   [ ] webos simulator
--   [ ] webos device
--   [ ] macos
--   [ ] windows
--   [ ] chromecast device
+n/a

packages/app-harness/renative.json

@@ -29,6 +29,9 @@
                 },
                 "podName": "react-native-splash-screen"
             },
+            "tvos": {
+                "disabled": true
+            },
             "version": "3.3.0"
         },
         "react-native-carplay": {
@@ -52,9 +55,17 @@
                 },
                 "podName": "react-native-carplay"
             },
+            "tvos": {
+                "disabled": true
+            },
             "version": "2.3.0"
         },
-        "react-native-permissions": "3.10.1",
+        "react-native-permissions": {
+            "tvos": {
+                "disabled": true
+            },
+            "version": "3.10.1"
+        },
         "react-native": {
             "android": {
                 "implementation": "// TEST"

packages/app-harness/src/app/index.tvos.tsx

@@ -0,0 +1,13 @@
+import React from 'react';
+import { Text, View } from 'react-native';
+
+const App = () => {
+    return (
+        <View>
+            <Text>ReNative Harness</Text>
+            <Text>{`hermes: ${typeof HermesInternal === 'object' && HermesInternal !== null ? 'yes' : 'no'}`}</Text>
+        </View>
+    );
+};
+
+export default App;

packages/cli/src/index.ts

@@ -34,6 +34,7 @@ export const run = () => {
             cmd += `-${param.shortcut}, `;
         }
         cmd += `--${param.key}`;
+
         if (param.value) {
             if (param.isRequired) {
                 cmd += ` <${param.value}>`;
@@ -46,7 +47,8 @@ export const run = () => {
         program.option(cmd, param.description);
     });
 
-    program.arguments('<cmd> [option]').action((cmd, option) => {
+    // Make both arguments optional un order to allow `$ rnv` top level command
+    program.arguments('[cmd] [option]').action((cmd, option) => {
         cmdValue = cmd;
         cmdOption = option;
     });

packages/cli/src/logger/index.ts

@@ -192,7 +192,7 @@ export const logSummary = (header = 'SUMMARY') => {
 
     if (_jsonOnly) return;
 
-    if (ctx.paths.project.configExists && !ctx.paths.IS_NPX_MODE) {
+    if (ctx.paths.project.configExists && !ctx.paths.IS_NPX_MODE && !ctx.paths.IS_LINKED) {
         logAndSave(chalk().yellow('You are trying to run global rnv command in your current project.'), true);
         logAndSave(chalk().yellow('This might lead to unexpected behaviour.'), true);
         logAndSave(chalk().yellow('Run your rnv command with npx prefix:'), true);

packages/core/src/api/defaults.ts

@@ -18,13 +18,43 @@ const spinner: any = () => ({
     text: '',
 });
 
-const logger: any = {};
+const defaultLog: any = (v: string) => {
+    console.log(`DEFAULT LOGGER: ${v}`);
+};
+const defaultGetString = () => '';
+const defaultGetBool = () => false;
 
 export const generateApiDefaults = (): RnvApi => ({
     isDefault: true,
     doResolve,
     getConfigProp: getConfigProp,
-    logger,
+    logger: {
+        printArrIntoBox: defaultLog,
+        getCurrentCommand: defaultGetString,
+        isInfoEnabled: defaultGetBool,
+        logAndSave: defaultLog,
+        chalk: defaultLog,
+        logAppInfo: defaultLog,
+        logComplete: defaultLog,
+        logDebug: defaultLog,
+        logEnd: defaultLog,
+        logError: defaultLog,
+        logExitTask: defaultLog,
+        logHook: defaultLog,
+        logInfo: defaultLog,
+        logInitialize: defaultLog,
+        logInitTask: defaultLog,
+        logRaw: defaultLog,
+        logSuccess: defaultLog,
+        logSummary: defaultLog,
+        logTask: defaultLog,
+        logToSummary: defaultLog,
+        logWarning: defaultLog,
+        logWelcome: defaultLog,
+        printBoxEnd: defaultLog,
+        printBoxStart: defaultLog,
+        printIntoBox: defaultLog,
+    },
     analytics: {
         captureEvent: () => {
             //NOOP

packages/core/src/configs/workspaces.ts

@@ -6,7 +6,7 @@ import path from 'path';
 import { chalk, logTask, logDebug, logInfo, logWarning } from '../logger';
 import { RnvContext } from '../context/types';
 import { generateOptions, inquirerPrompt } from '../api';
-import { ConfigFileWorkspaces } from '../schema/configFiles/types';
+import { ConfigFileWorkspace, ConfigFileWorkspaces } from '../schema/configFiles/types';
 
 export const createWorkspace = async (c: RnvContext, workspaceID: string, workspacePath: string) => {
     const cnf = c.files.rnv.configWorkspaces;
@@ -123,4 +123,10 @@ export const loadWorkspacesConfigSync = () => {
         };
         writeFileSync(c.paths.rnv.configWorkspaces, c.files.rnv.configWorkspaces);
     }
+
+    const defWsPath = c.paths.GLOBAL_RNV_CONFIG;
+
+    if (defWsPath && fsExistsSync(defWsPath)) {
+        c.files.defaultWorkspace.config = readObjectSync<ConfigFileWorkspace>(defWsPath) || {};
+    }
 };

packages/core/src/context/defaults.ts

@@ -26,6 +26,8 @@ export const generateRnvConfigFileObj = () => {
 };
 
 const runtime: RnvContext['runtime'] = {
+    plugins: {},
+    pluginVersions: {},
     enginesByPlatform: {},
     missingEnginePlugins: {},
     enginesByIndex: [],

packages/core/src/context/types.ts

@@ -18,6 +18,7 @@ import { NpmPackageFile } from '../configs/types';
 import { ConfigFileBuildConfig } from '../schema/configFiles/buildConfig';
 import type { ParamKeys } from '../tasks/constants';
 import { ExecaChildProcess } from 'execa';
+import { RnvPlugin } from '../plugins/types';
 
 export type CreateContextOptions = {
     program: RnvContextProgram;
@@ -137,6 +138,8 @@ export type RnvContextRuntime = {
     task?: string;
     selectedWorkspace?: string;
     target?: string;
+    plugins: Record<string, RnvPlugin>;
+    pluginVersions: Record<string, string>;
 };
 
 export type RuntimePropKey = keyof RnvContextRuntime;

packages/core/src/engines/index.ts

@@ -188,11 +188,13 @@ export const loadEnginePluginDeps = async (c: RnvContext, engineConfigs: Array<R
         }
     });
     if (hasAddedPlugins) {
-        const engines = Object.keys(addedPlugins);
-        const allPlugins = Object.keys(originalProjectPlugins);
+        const engineKeys = engineConfigs.map((v) => v.key);
+        const addedPluginsKeys = Object.keys(addedPlugins);
+
+        // const allPlugins = Object.keys(originalProjectPlugins);
         logInfo(
-            `Engines: ${chalk().yellow(engines.join(','))} require plugins ${chalk().white(
-                allPlugins.join(',')
+            `Engines: ${chalk().yellow(engineKeys.join(','))} require plugins ${chalk().white(
+                addedPluginsKeys.join(',')
             )} to be added to ${chalk().white(c.paths.project.config)}`
         );
         const confirm = await inquirerPrompt({
@@ -202,7 +204,7 @@ export const loadEnginePluginDeps = async (c: RnvContext, engineConfigs: Array<R
 If you don't want to use this dependency make sure you remove platform which requires this engine from supportedPlatforms`,
         });
         if (confirm) {
-            logInfo(`Adding ${allPlugins.join(',')}. ...DONE`);
+            logInfo(`Adding ${addedPluginsKeys.join(',')}. ...DONE`);
             // Prepare original file to be decorated (as addon plugins as we can't edit template itself)
             cnf.plugins = originalProjectPlugins;
             writeRenativeConfigFile(c, c.paths.project.config, cnf);
@@ -448,7 +450,6 @@ const _resolvePkgPath = (c: RnvContext, packageName: string) => {
         // In the instances of running linked rnv instead of installed one load local packages
         try {
             let pkgPathLocal = require.resolve(packageName, { paths: [path.join(c.paths.rnv.dir, '..')] });
-            //TODO: this needs to be changed to support ts libs
             pkgPathLocal = pkgPathLocal
                 .replace('/dist/index.js', '')
                 .replace('\\dist\\index.js', '')
@@ -556,4 +557,4 @@ export const getEngineRunner = (c: RnvContext, task: string, customTasks?: RnvTa
     return undefined;
 };
 
-export const getRegisteredEngines = (c: RnvContext) => c.runtime.enginesByIndex;
+export const getRegisteredEngines = (c: RnvContext) => c.runtime.enginesByIndex;

packages/core/src/plugins/index.ts

@@ -372,7 +372,8 @@ export const parsePlugins = (
     c: RnvContext,
     platform: RnvPlatform,
     pluginCallback: PluginCallback,
-    ignorePlatformObjectCheck?: boolean
+    ignorePlatformObjectCheck?: boolean,
+    includeDisabledPlugins?: boolean
 ) => {
     logTask('parsePlugins');
     if (c.buildConfig && platform) {
@@ -391,34 +392,43 @@ export const parsePlugins = (
 
                         if (plugin) {
                             const pluginPlat = plugin[platform] || {};
+
+                            const handleActivePlugin = () => {
+                                if (pluginCallback) {
+                                    c.runtime.plugins[key] = plugin;
+                                    if (plugin.version) {
+                                        c.runtime.pluginVersions[key] = plugin.version;
+                                    }
+                                    pluginCallback(plugin, pluginPlat, key);
+                                }
+                            };
+
                             // NOTE: we do not want to disable plugin just because object is missing. instead we will let people to do it explicitly
                             // {
                             //     skipLinking: true,
                             //     disabled: true,
-                            //     enabled: false,
                             // };
+                            //TODO: consider supportedPlatforms for plugins
                             if (ignorePlatformObjectCheck) {
                                 // totalIncludedPlugins++;
-                                pluginCallback(plugin, pluginPlat, key);
+                                handleActivePlugin();
                             } else if (pluginPlat) {
                                 const isPluginDisabled = plugin.disabled === true;
-                                //DEPreCATED
-                                const isPluginPlatDisabled =
-                                    pluginPlat.disabled === true || pluginPlat.enabled === false;
+                                const isPluginPlatDisabled = pluginPlat.disabled === true;
                                 if (!isPluginDisabled && !isPluginPlatDisabled) {
                                     if (plugin.deprecated) {
                                         logWarning(plugin.deprecated);
                                     }
-                                    if (pluginCallback) {
-                                        // totalIncludedPlugins++;
-                                        pluginCallback(plugin, pluginPlat, key);
-                                    }
+                                    handleActivePlugin();
                                 } else {
                                     if (isPluginDisabled) {
                                         logInfo(`Plugin ${key} is marked disabled. skipping.`);
                                     } else if (isPluginPlatDisabled) {
                                         logInfo(`Plugin ${key} is marked disabled for platform ${platform} skipping.`);
                                     }
+                                    if (includeDisabledPlugins) {
+                                        handleActivePlugin();
+                                    }
                                 }
                             }
                         }

packages/core/src/schema/configFiles/project.ts

@@ -147,8 +147,6 @@ const EnableHookRebuild = z
         'If set to true in `./renative.json` build hooks will be compiled at each rnv command run. If set to `false` (default) rebuild will be triggered only if `dist` folder is missing, `-r` has been passed or you run `rnv hooks run` directly making your rnv commands faster'
     );
 
-const EnableAnalytics = z.boolean().describe('Enable or disable sending analytics to improve ReNative');
-
 const ProjectName = z
     .string()
     .describe(
@@ -226,7 +224,6 @@ const RootProjectBaseFragment = {
     custom: z.optional(Ext),
     enableHookRebuild: z.optional(EnableHookRebuild),
     monoRoot: z.optional(MonoRoot),
-    enableAnalytics: z.optional(EnableAnalytics),
     extendsTemplate: z.optional(ExtendTemplate),
     tasks: z.optional(Tasks),
     integrations: z.optional(Integrations),

packages/core/src/schema/configFiles/workspace.ts

@@ -21,7 +21,11 @@ const SDKsSchema = z
 export const RootWorkspaceSchema = z.object({
     defaultTargets: z.optional(DefaultTargets),
     sdks: z.optional(SDKsSchema),
-    projectTemplates: z.record(z.string(), z.object({})),
+    projectTemplates: z.record(z.string(), z.object({})).optional(),
+    disableTelemetry: z
+        .boolean()
+        .optional()
+        .describe('Opt-out from renative telemetry program. More info at https://renative.org/telemetry'),
     appConfigsPath: z
         .string()
         .optional()

packages/core/src/schema/plugins/fragments/base.ts

@@ -62,7 +62,6 @@ export const PluginBaseFragment = {
     webpackConfig: z.optional(Webpack), //Should this be at root plugin???
     disablePluginTemplateOverrides: z.optional(DisablePluginTemplateOverrides),
     fontSources: z.array(z.string()).optional(),
-    // enabled: z.optional(Enabled), //DEPRECATED => disabled
     // 'no-npm': z.optional(NoNpm),//DEPRECATED => disableNpm
     // plugins: z.optional(PluginDependencies),  //DEPRECATED => pluginDependencies
     // webpack: z.optional(Webpack), //Should this be at root plugin??? // DEPRECATED