Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add translation for iterm2 #25477

Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix: add translation for iterm2 #25477

merged 3 commits into from
Jan 17, 2025

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Jan 15, 2025

For #25130

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (70096e8) to head (07a0361).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25477   +/-   ##
=======================================
  Coverage   63.59%   63.59%           
=======================================
  Files        1619     1619           
  Lines      154976   154980    +4     
  Branches     4038     4038           
=======================================
+ Hits        98559    98564    +5     
+ Misses      48648    48647    -1     
  Partials     7769     7769           
Flag Coverage Δ
backend 64.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahzielv jahzielv marked this pull request as ready for review January 16, 2025 14:21
@jahzielv jahzielv requested a review from a team as a code owner January 16, 2025 14:21
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked changes file to focus on impact rather than implementation details. Otherwise LGTM!

changes/25130-iterm-false-neg Outdated Show resolved Hide resolved
@jahzielv jahzielv merged commit 8407aef into main Jan 17, 2025
32 checks passed
@jahzielv jahzielv deleted the 25130-iterm-false-neg branch January 17, 2025 01:17
jahzielv added a commit that referenced this pull request Jan 17, 2025
> For #25130 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
jahzielv added a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants