Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add translation for iterm2 (#25477) #25541

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jahzielv
Copy link
Contributor

cherry-pick for #25477

> For #25130 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
@jahzielv jahzielv requested a review from a team as a code owner January 17, 2025 14:03
@jahzielv jahzielv merged commit 77de97e into rc-minor-fleet-v4.63.0 Jan 17, 2025
23 checks passed
@jahzielv jahzielv deleted the 25130-iterm-false-neg-cherry-pick branch January 17, 2025 14:25
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rc-minor-fleet-v4.63.0@d611075). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.63.0   #25541   +/-   ##
=========================================================
  Coverage                          ?   63.58%           
=========================================================
  Files                             ?     1619           
  Lines                             ?   154939           
  Branches                          ?     4038           
=========================================================
  Hits                              ?    98524           
  Misses                            ?    48646           
  Partials                          ?     7769           
Flag Coverage Δ
backend 64.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants