Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add translation for iterm2 #25477

Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix: add translation for iterm2 #25477

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36071f7
fix: add translation for iterm2
jahzielv Jan 15, 2025
6125507
chore: changes file
jahzielv Jan 16, 2025
07a0361
chore: changes file
jahzielv Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/25130-iterm-false-neg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixed a false negative vulnerability reporting for iTerm2 by adding a CPE translation.
jahzielv marked this conversation as resolved.
Show resolved Hide resolved
12 changes: 11 additions & 1 deletion server/vulnerabilities/nvd/cpe_translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,5 +545,15 @@
"product": ["cli"],
"vendor": ["github"]
}
},
{
"software": {
"bundle_identifier": ["/^com\\.googlecode\\.iterm2/"],
"source": ["apps"]
},
"filter": {
"product": ["iterm2"],
"vendor": ["iterm2"]
}
}
]
]
3 changes: 3 additions & 0 deletions server/vulnerabilities/nvd/cve_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,9 @@ func TestTranslateCPEToCVE(t *testing.T) {
excludedCVEs: []string{"CVE-2024-37051"},
continuesToUpdate: true,
},
"cpe:2.3:a:iterm2:iterm2:3.5.2:*:*:*:*:*:*:*": {
includedCVEs: []cve{{ID: "CVE-2024-38395", resolvedInVersion: ""}},
},
}

cveOSTests := []struct {
Expand Down
Loading