Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #1543

Merged
merged 3 commits into from
Oct 10, 2022
Merged

minor improvements #1543

merged 3 commits into from
Oct 10, 2022

Conversation

irisyngao
Copy link
Contributor

@irisyngao irisyngao commented Oct 7, 2022

Summary

Fixes #1542

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022

🦋 Changeset detected

Latest commit: 5918f4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-graph Patch
@finos/legend-query-builder Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence-cloud Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-format-morphir Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query Patch
@finos/legend-application-taxonomy Patch
@finos/legend-application Patch
@finos/legend-extension-format-json-schema Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #1543 (5918f4f) into master (f3007ac) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #1543      +/-   ##
==========================================
- Coverage   40.58%   40.57%   -0.02%     
==========================================
  Files        1264     1264              
  Lines       56277    56295      +18     
  Branches    12708    12718      +10     
==========================================
+ Hits        22842    22843       +1     
- Misses      33353    33370      +17     
  Partials       82       82              
Impacted Files Coverage Δ
...rc/components/editor/edit-panel/FunctionEditor.tsx 14.46% <ø> (ø)
...editor/edit-panel/uml-editor/AssociationEditor.tsx 74.28% <0.00%> (ø)
...nents/editor/edit-panel/uml-editor/ClassEditor.tsx 51.07% <0.00%> (ø)
...rc/components/studio/DSL_Diagram_DiagramEditor.tsx 10.97% <0.00%> (-0.04%) ⬇️
...re/STO_ServiceStore_PureProtocolProcessorPlugin.ts 85.79% <0.00%> (ø)
.../pureGraph/to/helpers/V1_MilestoneBuilderHelper.ts 65.11% <ø> (ø)
...h/to/helpers/V1_ValueSpecificationBuilderHelper.ts 24.32% <0.00%> (ø)
...der/src/components/QueryBuilderParametersPanel.tsx 41.90% <ø> (ø)
...re/v1/V1_QueryBuilder_FunctionExpressionBuilder.ts 100.00% <ø> (ø)
...QueryBuilderProjectionValueSpecificationBuilder.ts 95.74% <100.00%> (ø)
... and 3 more

@irisyngao irisyngao self-assigned this Oct 10, 2022
@MauricioUyaguari MauricioUyaguari merged commit a6830b4 into finos:master Oct 10, 2022
@akphi akphi deleted the codeRefactor branch October 10, 2022 22:24
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Oct 11, 2022
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Oct 11, 2022
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Oct 12, 2022
remove multiplicty observer
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Oct 12, 2022
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Oct 12, 2022
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Oct 12, 2022
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Oct 12, 2022
akphi pushed a commit that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Minor improvements -- Improve the way of creating a multiplicity
2 participants