Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a regression introduced in #1543 #1553

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

irisyngao
Copy link
Contributor

@irisyngao irisyngao commented Oct 12, 2022

Summary

BREAKING CHANGE: Make multiplicity's upper bound and lower bond readonly.

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

🦋 Changeset detected

Latest commit: 1d0b820

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-graph Major
@finos/legend-query-builder Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence-cloud Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-format-morphir Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-application-taxonomy Patch
@finos/legend-application Patch
@finos/legend-extension-format-json-schema Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1553 (1d0b820) into master (240875e) will increase coverage by 0.00%.
The diff coverage is 14.28%.

@@           Coverage Diff           @@
##           master    #1553   +/-   ##
=======================================
  Coverage   40.89%   40.89%           
=======================================
  Files        1270     1270           
  Lines       56416    56404   -12     
  Branches    12728    12728           
=======================================
- Hits        23070    23069    -1     
+ Misses      33261    33250   -11     
  Partials       85       85           
Impacted Files Coverage Δ
...tores/shared/modifier/DomainGraphModifierHelper.ts 35.54% <0.00%> (ø)
...difier/RawValueSpecificationGraphModifierHelper.ts 33.33% <0.00%> (ø)
...changeDetection/STO_ServiceStore_ObserverHelper.ts 24.39% <ø> (+0.14%) ⬆️
...el/pure/packageableElements/domain/Multiplicity.ts 100.00% <ø> (ø)
...nager/action/changeDetection/CoreObserverHelper.ts 11.76% <ø> (+1.23%) ⬆️
...tion/changeDetection/DSL_Mapping_ObserverHelper.ts 5.13% <ø> (+0.01%) ⬆️
...ger/action/changeDetection/DomainObserverHelper.ts 8.28% <ø> (+0.14%) ⬆️
...n/changeDetection/RawValueSpecificationObserver.ts 0.00% <ø> (ø)
...tion/changeDetection/ValueSpecificationObserver.ts 3.53% <ø> (+0.03%) ⬆️
...der/src/components/QueryBuilderParametersPanel.tsx 41.90% <ø> (ø)
... and 4 more

@irisyngao irisyngao force-pushed the fixMultiplicity branch 2 times, most recently from a2c3b34 to eecb3e9 Compare October 12, 2022 16:07
@irisyngao irisyngao marked this pull request as draft October 12, 2022 16:07
Copy link
Contributor

@akphi akphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but you would need to update the changeset. Thanks!

@irisyngao irisyngao self-assigned this Oct 12, 2022
@irisyngao irisyngao added this to the 8.0.0 milestone Oct 12, 2022
@irisyngao irisyngao marked this pull request as ready for review October 12, 2022 18:17
@akphi akphi merged commit f8e745c into finos:master Oct 12, 2022
@akphi akphi deleted the fixMultiplicity branch October 12, 2022 18:57
@akphi akphi added the Type: Regression A bug that did not exist in previous versions label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed Type: Regression A bug that did not exist in previous versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants