-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a regression introduced in #1543 #1553
Conversation
🦋 Changeset detectedLatest commit: 1d0b820 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/legend-graph/src/graph/metamodel/pure/packageableElements/domain/Multiplicity.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1553 +/- ##
=======================================
Coverage 40.89% 40.89%
=======================================
Files 1270 1270
Lines 56416 56404 -12
Branches 12728 12728
=======================================
- Hits 23070 23069 -1
+ Misses 33261 33250 -11
Partials 85 85
|
a2c3b34
to
eecb3e9
Compare
eecb3e9
to
5bab5a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but you would need to update the changeset. Thanks!
5bab5a2
to
8c386f1
Compare
8c386f1
to
1d0b820
Compare
Summary
BREAKING CHANGE: Make multiplicity's upper bound and lower bond
readonly
.How did you test this change?