Add parameter multiplicity validation for service registration #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: efea3c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
+ Coverage 40.57% 40.59% +0.01%
==========================================
Files 1264 1264
Lines 56295 56284 -11
Branches 12718 12708 -10
==========================================
+ Hits 22843 22847 +4
+ Misses 33370 33355 -15
Partials 82 82
|
MauricioUyaguari
requested changes
Oct 6, 2022
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
| this.editorStore.applicationStore.notifyError( | ||
| `Multiplicy of ${params.map( | ||
| (p) => p.name, | ||
| )} is/are [1..*], which is not in the allowed range for MANY multiplicity. Please use [*], [0..*] instead.`, |
There was a problem hiding this comment.
Lets confirm the list of accepted Multiplicies
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
MauricioUyaguari
requested changes
Oct 6, 2022
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
MauricioUyaguari
requested changes
Oct 6, 2022
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
...tion-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts
Outdated
Show resolved
Hide resolved
fd5e645 to
4eee71f
Compare
| ); | ||
| assertTrue( | ||
| invalidParams.length === 0, | ||
| `${invalidParams.map( |
There was a problem hiding this comment.
Parameters p1:[1..], p2:[1..] have unsupported multiplicities
akphi
reviewed
Oct 8, 2022
| ) | ||
| .filter(filterByType(VariableExpression)) | ||
| .filter( | ||
| (p) => !supportedServiceParamMultiplicties.includes(p.multiplicity), |
There was a problem hiding this comment.
don't think we can always assume multiplicity comes from the same graph and the multiplicity index. The most appropriate check here is to do the comparison by lower and upper bounds. The fact we cache multiplicities in the graph is just small optimization, we don't require other coders to have to know about it. I think it's best to create a comparator helper for multiplicity and use this. I almost guarantee this might cause a bug some day 🤷
There was a problem hiding this comment.
yeah in terms of bugs i think we could just use comparator. we should try to always use the getMultiplicity though so they are still the same object.
but in this casse if they happen to be different objects we should still not allow the ones with unsupported multiplicities.
62a625c to
8a435af
Compare
improve condition and error messages improve error message add a comparator for multiplicity
8a435af to
cfe3a4c
Compare
MauricioUyaguari
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a parameter multiplicity validation when registering a service.
For MANY multiplicity, the allowed range is [0..*, .., ].
If users try to use [1..] or others that have *, Studio will throw an error notification.
Fixes #1539
Depends on #1543
How did you test this change?