add parameter multiplicity validation for service registration (#1538)

* Add a parameter multiplicity validation for service registration

improve condition and error messages

improve error message

add a comparator for multiplicity

* add one changeset

.changeset/seven-flowers-sparkle.md

@@ -0,0 +1,3 @@
+---
+'@finos/legend-graph': patch
+---

.changeset/strong-lions-thank.md

@@ -0,0 +1,5 @@
+---
+'@finos/legend-application-studio': patch
+---
+
+Add service parameter multiplicity validation during service registration ([#1539](https://github.com/finos/legend-studio/issues/1539)).

packages/legend-application-studio/src/stores/editor-state/element-editor-state/service/ServiceRegistrationState.ts

@@ -29,13 +29,20 @@ import {
   getNullableFirstElement,
   assertTrue,
   URL_SEPARATOR,
+  filterByType,
 } from '@finos/legend-shared';
 import { LEGEND_STUDIO_APP_EVENT } from '../../../LegendStudioAppEvent.js';
 import { Version } from '@finos/legend-server-sdlc';
 import {
   type Service,
   type ServiceRegistrationResult,
+  type PureExecution,
   ServiceExecutionMode,
+  buildLambdaVariableExpressions,
+  VariableExpression,
+  TYPICAL_MULTIPLICITY_TYPE,
+  generateMultiplicityString,
+  multiplicityComparator,
 } from '@finos/legend-graph';
 import { ServiceRegistrationEnvironmentConfig } from '../../../../application/LegendStudioApplicationConfig.js';
 import {
@@ -314,5 +321,37 @@ export class ServiceRegistrationState {
         'Service version can not be empty in Semi-interactive and Prod service type',
       );
     }
+
+    // validate service parameter multiplicities
+    const supportedServiceParamMultiplicties = [
+      TYPICAL_MULTIPLICITY_TYPE.ONE,
+      TYPICAL_MULTIPLICITY_TYPE.ZEROMANY,
+      TYPICAL_MULTIPLICITY_TYPE.ZEROONE,
+    ].map((p) =>
+      this.editorStore.graphManagerState.graph.getTypicalMultiplicity(p),
+    );
+    const invalidParams = buildLambdaVariableExpressions(
+      (this.service.execution as PureExecution).func,
+      this.editorStore.graphManagerState,
+    )
+      .filter(filterByType(VariableExpression))
+      .filter(
+        (p) =>
+          !supportedServiceParamMultiplicties.some((m) =>
+            multiplicityComparator(m, p.multiplicity),
+          ),
+      );
+    assertTrue(
+      invalidParams.length === 0,
+      `Parameter(s)${invalidParams.map(
+        (p) =>
+          ` ${p.name}: [${generateMultiplicityString(
+            p.multiplicity.lowerBound,
+            p.multiplicity.upperBound,
+          )}]`,
+      )} has/have unsupported multiplicity. Supported multiplicities include ${supportedServiceParamMultiplicties.map(
+        (m) => ` [${generateMultiplicityString(m.lowerBound, m.upperBound)}]`,
+      )}.`,
+    );
   }
 }

packages/legend-graph/src/graph/helpers/DomainHelper.ts

@@ -553,6 +553,12 @@ export const getMultiplicityDescription = (
   }`;
 };
 
+export const multiplicityComparator = (
+  mul1: Multiplicity,
+  mul2: Multiplicity,
+): boolean =>
+  mul1.upperBound === mul2.upperBound && mul1.lowerBound === mul2.lowerBound;
+
 export const isElementDeprecated = (
   element: AnnotatedElement | Class,
   graph: PureModel,