Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder transfer checks so as to ensure sending 2B FIL to yourself fails if you don't have that amount #7637

Merged
merged 7 commits into from
Nov 29, 2021

Conversation

laudiacay
Copy link
Contributor

Fixes #7596.

@laudiacay laudiacay requested a review from a team as a code owner November 17, 2021 20:15
@jennijuju
Copy link
Member

is this rebased onto or based off the right branch?

@laudiacay laudiacay changed the base branch from next to asr/v7-actors November 18, 2021 18:00
Base automatically changed from asr/v7-actors to next November 19, 2021 20:25
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

chain/vm/vm.go Outdated Show resolved Hide resolved
chain/vm/vm.go Outdated Show resolved Hide resolved
chain/vm/vm.go Show resolved Hide resolved
chain/vm/runtime.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #7637 (187a392) into next (9d44893) will increase coverage by 0.04%.
The diff coverage is 42.55%.

❗ Current head 187a392 differs from pull request most recent head 6fa8d40. Consider uploading reports for the commit 6fa8d40 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7637      +/-   ##
==========================================
+ Coverage   39.50%   39.55%   +0.04%     
==========================================
  Files         646      646              
  Lines       68376    68400      +24     
==========================================
+ Hits        27015    27054      +39     
+ Misses      36722    36702      -20     
- Partials     4639     4644       +5     
Impacted Files Coverage Δ
chain/vm/runtime.go 54.20% <0.00%> (ø)
chain/vm/vm.go 63.34% <43.47%> (+0.33%) ⬆️
blockstore/api.go 24.00% <0.00%> (-8.00%) ⬇️
blockstore/blockstore.go 62.96% <0.00%> (-7.41%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
chain/actors/builtin/market/v7.go 45.16% <0.00%> (-1.62%) ⬇️
extern/storage-sealing/fsm.go 55.77% <0.00%> (-1.20%) ⬇️
chain/events/state/predicates.go 53.09% <0.00%> (-1.04%) ⬇️
chain/messagepool/messagepool.go 57.79% <0.00%> (-0.62%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d44893...6fa8d40. Read the comment docs.

itests/self_sent_txn_test.go Show resolved Hide resolved
@laudiacay laudiacay merged commit e16e9ad into next Nov 29, 2021
@laudiacay laudiacay deleted the fix/7596 branch November 29, 2021 22:26
@jennijuju jennijuju added this to the v1.14.0 milestone Jan 3, 2022
jennijuju pushed a commit that referenced this pull request Jan 11, 2022
… have to yourself fails with an error (fixing issue 7596)

PR #7637, also adds tests to make sure behavior is correct across versions.
jennijuju pushed a commit that referenced this pull request Jan 14, 2022
… have to yourself fails with an error (fixing issue 7596)

PR #7637, also adds tests to make sure behavior is correct across versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants