-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorder transfer
checks so as to ensure sending 2B FIL to yourself fails if you don't have that amount
#7637
Conversation
is this rebased onto or based off the right branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits
Codecov Report
@@ Coverage Diff @@
## next #7637 +/- ##
==========================================
+ Coverage 39.50% 39.55% +0.04%
==========================================
Files 646 646
Lines 68376 68400 +24
==========================================
+ Hits 27015 27054 +39
+ Misses 36722 36702 -20
- Partials 4639 4644 +5
Continue to review full report at Codecov.
|
… have to yourself fails with an error (fixing issue 7596) PR #7637, also adds tests to make sure behavior is correct across versions.
… have to yourself fails with an error (fixing issue 7596) PR #7637, also adds tests to make sure behavior is correct across versions.
Fixes #7596.