Tweak self-transfer behaviour to match v15 #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Mar 8, 2022
| @@ -214,6 +210,15 @@ where | |||
| .context("cannot transfer from non-existent sender") | |||
| .or_error(ErrorNumber::InsufficientFunds)?; | |||
|
|
|||
| if from_actor.balance.lt(value) { | |||
There was a problem hiding this comment.
Can we not just use from_actor.balance < value?
I.e https://m.filscout.com/zh/message/bafy2bzacebr2quxfina5pcy3uudh5lhrbapmbdaxd3l5qfkfhaun6yq44qxmu |
|
Heh. Lol. But if there's nothing recent, we're probably fine merging without a guard (this is just for testing). |
raulk
requested changes
Mar 9, 2022
|
Yeah, opened this before the discussion that resulted in #360 (comment) |
|
Pulling into #360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
Matches behaviour in filecoin-project/lotus#7637.
The motivation for this change is mostly around UX -- it appears weird when people successfully send themselves 2B Filecoin, even though no actual transfer occurs. This change is slightly less efficient than exiting early on self-transfers, but that's not really a case we're looking to optimize.