infra(eslint): logical-assignment-operators #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2656 +/- ##
==========================================
- Coverage 99.93% 99.93% -0.01%
==========================================
Files 2958 2958
Lines 213713 213713
Branches 601 946 +345
==========================================
- Hits 213574 213567 -7
- Misses 139 142 +3
- Partials 0 4 +4 |
ST-DDT
reviewed
Feb 9, 2024
422c4d4 to
e8d0273
Compare
e8d0273 to
c237c30
Compare
xDivisionByZerox
previously approved these changes
Mar 3, 2024
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
17fc929 to
9a3ef16
Compare
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ST-DDT
approved these changes
Mar 18, 2024
ejcheng
approved these changes
Mar 18, 2024
xDivisionByZerox
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permanently enables the
logical-assignment-operatorslint rule.This will be in draft until we merged the deprecation PRs, because this will reduce the diff to only affect 1 line in test.