Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
  • Loading branch information
Shinigami92 and ST-DDT committed Feb 16, 2024
1 parent bd11c44 commit c237c30
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions test/modules/finance.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,7 @@ describe('finance', () => {
});

it('should set a specified length', () => {
let expected = faker.number.int(20);

expected ||= 4;
const expected = faker.number.int(20) || 4;

const mask = faker.finance.mask(expected, false, false); // the length of mask picks 4 if the random number generator picks 0

Expand Down Expand Up @@ -237,9 +235,7 @@ describe('finance', () => {
});

it('should set a specified length', () => {
let expected = faker.number.int(20);

expected ||= 4;
const expected = faker.number.int(20) || 4;

const mask = faker.finance.maskedNumber({
length: expected,
Expand Down

0 comments on commit c237c30

Please sign in to comment.