Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(finance): improve readability #2766

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 23, 2024

@ST-DDT ST-DDT added this to the vAnytime milestone Mar 23, 2024
@ST-DDT ST-DDT requested review from a team March 23, 2024 22:40
@ST-DDT ST-DDT self-assigned this Mar 23, 2024
Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 1a1c3f2
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66001f18344685000800ff9d
😎 Deploy Preview https://deploy-preview-2766.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (df1c83d) to head (1a1c3f2).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2766   +/-   ##
=======================================
  Coverage   99.93%   99.94%           
=======================================
  Files        2958     2958           
  Lines      213713   213713           
  Branches      949      950    +1     
=======================================
+ Hits       213580   213587    +7     
+ Misses        133      122   -11     
- Partials        0        4    +4     

see 5 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: test m: finance Something is referring to the finance module labels Mar 24, 2024
@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) March 24, 2024 12:39
@xDivisionByZerox xDivisionByZerox merged commit 45150d1 into next Mar 24, 2024
20 checks passed
@xDivisionByZerox xDivisionByZerox deleted the chore/test/cleanup branch March 24, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants