Update EthersStateManager to be RpcStateManager under the hood
#3167
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
EtherStateManager blockchain supplemental workEthersStateManager to be RpcStateManager under the hood
| if (typeof opts.provider === 'string') { | ||
| this._provider = new ethers.JsonRpcProvider(opts.provider) | ||
| } else if (opts.provider instanceof ethers.JsonRpcProvider) { | ||
| if (typeof opts.provider === 'string' && opts.provider.startsWith('http')) { |
There was a problem hiding this comment.
This is fine, but just noting: we thus do not have websocket support. (Also does not seem that fetchFromProvider accepts this)
There was a problem hiding this comment.
Correct. This only works over HTTP. If anyone ever asks about websocket support, we can explore it. I'm not sure if node's native fetch instance supports WS anyway.
There was a problem hiding this comment.
If ws are added in future you might need to use an isomorphic library or dependency inject it to get it to work in both client and node
|
I don't understand, tests and linter fail locally (also after a fresh build), but not on CI? 😓 |
|
Nvm, did not pull 🤦 |
b8daaa6 to
58eb39c
Compare
There was a problem hiding this comment.
This is amazing! Big improvement from pulling in viem or ethers.js to do something that can be done with this much less code.
I noticed the error handling on fetchFromProvider was less than ideal so I opened a PR to improve it: #3171
| if (typeof opts.provider === 'string') { | ||
| this._provider = new ethers.JsonRpcProvider(opts.provider) | ||
| } else if (opts.provider instanceof ethers.JsonRpcProvider) { | ||
| if (typeof opts.provider === 'string' && opts.provider.startsWith('http')) { |
There was a problem hiding this comment.
If ws are added in future you might need to use an isomorphic library or dependency inject it to get it to work in both client and node
packages/statemanager/test/testdata/providerData/mockProvider.ts
Outdated
Show resolved
Hide resolved
e02ed1b to
d0b4bd6
Compare
Several improvements for
EthersStateManagerethersdependency and replace with raw JSON RPC calls similar toBlock.fromJsonRpcProviderblockchainclass that mimics existingevmDefaultBlockchainbehavior - has benefit of fixing issue whereBLOCKHASHopcode wouldn't work right underEthersStateManagerEthersStateManagertests with better mocks for JSON-RPC provider