Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runCallOpts and runCodeOpts to evm exports #3172

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

acolytec3
Copy link
Contributor

While working on #3167, I noticed that we do not export EVMRunCallOpts and EVMRunCodeOpts from the evm package even though these are the type definitions for the evm.runCall and evm.runCode public methods of the EVM. This fixes that.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #3172 (5279847) into master (9d756c2) will decrease coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.80% <ø> (ø)
blockchain 91.61% <ø> (ø)
client 84.86% <ø> (-0.05%) ⬇️
common 98.19% <ø> (ø)
devp2p 82.09% <ø> (?)
ethash ∅ <ø> (∅)
evm 73.53% <100.00%> (+1.59%) ⬆️
statemanager 90.13% <ø> (ø)
trie 89.76% <ø> (+0.04%) ⬆️
tx 95.73% <ø> (ø)
util 88.90% <ø> (ø)
vm 81.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@acolytec3 acolytec3 merged commit 5d12ee6 into master Nov 30, 2023
@holgerd77 holgerd77 deleted the export-evm-run-opts branch December 1, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants