Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update
EthersStateManager
to be RpcStateManager under the hood #3167Update
EthersStateManager
to be RpcStateManager under the hood #3167Changes from 8 commits
b163500
b1b828f
c62f4b0
9ecf155
43dc252
7541161
783cbe3
aa8dc5e
58eb39c
0a21fc1
5a701b1
c8667f2
a68e5cb
1985e6c
8dafd00
168c9b9
323bb78
d0b4bd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but just noting: we thus do not have websocket support. (Also does not seem that
fetchFromProvider
accepts this)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. This only works over HTTP. If anyone ever asks about websocket support, we can explore it. I'm not sure if node's native
fetch
instance supports WS anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If ws are added in future you might need to use an isomorphic library or dependency inject it to get it to work in both client and node