Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JTAG Flash Support (VSC-487) #183

Merged
merged 27 commits into from
Dec 28, 2020
Merged

JTAG Flash Support (VSC-487) #183

merged 27 commits into from
Dec 28, 2020

Conversation

pwmb
Copy link
Contributor

@pwmb pwmb commented Sep 29, 2020 •
edited
Loading

This feature will enable to flash device via JTAG

TODOs:
  • Add i18n
  • Restrict simultaneous flash via UART & JTAG

Closes #161

How to test?
  • Set the settings idf.flashType as JTAG and click flash button and it should use the functionality for flashing via JTAG
Developers Note

OpenOCD Version Requirements: v0.10.0-esp32-20201125 and above

Awaits release and backport to IDF

pwmb added 18 commits March 16, 2020 18:19
@pwmb
Merge pull request #1 from espressif/master
069c1b1 
Merge master from espressif/vscode-esp-idf-extension
@pwmb
Merge pull request #2 from espressif/master
00dbd8c 
Merge commit
@pwmb
Merge pull request #3 from espressif/master
08e1a73 
Master merge
@pwmb
Merge pull request #4 from espressif/master
4222336 
merge from GH master
@pwmb
Merge pull request #5 from espressif/master
c14e9d4 
Sync Merge
@pwmb
Merge pull request #6 from espressif/master
54e9adc 
Sync
@pwmb
Merge pull request #7 from espressif/master
4a74d72 
Sync
@pwmb
Merge pull request #8 from espressif/master
54f0601 
Sync with master
@pwmb
Merge pull request #9 from espressif/master
e259f59 
Github Master sync
@pwmb
Merge pull request #10 from espressif/master
8378ff1 
Sync
@pwmb
Merge branch 'master' of github.com:pwmb/vscode-esp-idf-extension
8d00919
@pwmb
Merge branch 'master' of github.com:pwmb/vscode-esp-idf-extension
b461fa7
@pwmb
Merge remote-tracking branch 'upstream/master'
a658551
@pwmb
Merge remote-tracking branch 'upstream/master'
9c9615d
@pwmb
Merge pull request #11 from espressif/master
40f1447 
sync
@pwmb
Add JTag Flash support
42f4e2b
@pwmb
Add types for event listeners
5f6c0d8
@pwmb
Add option to select flash mode
26fb6bb
@pwmb pwmb added Feature A new feature Release: Awaited for Dependencies Awaiting release due to dependencies and their release first labels Sep 29, 2020
@pwmb pwmb added this to the Release Candidate v0.6.0 milestone Sep 29, 2020
@pwmb pwmb self-assigned this Sep 29, 2020
@github-actions
Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Oct 15, 2020
@brianignacio5 brianignacio5 removed the stale Stale PR or Issue label Oct 15, 2020
@pwmb pwmb added the ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot label Oct 15, 2020
@github-actions github-actions bot changed the title JTAG Flash Support JTAG Flash Support (VSC-487) Nov 26, 2020
brianignacio5
brianignacio5 requested changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MacOS. Feature looks really well and working properly.

Left some comments otherwise LGTM.

src/extension.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@pwmb pwmb requested a review from brianignacio5 December 1, 2020 12:05
brianignacio5
brianignacio5 approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pwmb pwmb requested a review from brianignacio5 December 10, 2020 13:44
@pwmb pwmb merged commit 354531e into espressif:master Dec 28, 2020
@pwmb pwmb deleted the feature/jtag-flash-support branch December 28, 2020 10:32
@pwmb pwmb modified the milestones: Release Candidate v0.6.0, next Dec 28, 2020
@karlp karlp mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerekon gerekon Awaiting requested review from gerekon

@brianignacio5 brianignacio5 Awaiting requested review from brianignacio5

Assignees

@pwmb pwmb

Labels
Feature A new feature ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot Release: Awaited for Dependencies Awaiting release due to dependencies and their release first
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Upload firmware via jtag. (VSC-427)
2 participants
@pwmb @brianignacio5