Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense engine to search for headers automatically (VSC-165) #2

Merged
merged 3 commits into from
Jan 19, 2020
Merged

Intellisense engine to search for headers automatically (VSC-165) #2

merged 3 commits into from
Jan 19, 2020

Conversation

boarchuz
Copy link
Contributor

This adds wildcards to the includePath (documented here: https://code.visualstudio.com/docs/cpp/c-cpp-properties-schema-reference#_configuration-properties) so that the Intellisense engine will search within the esp32/components folder and discover all header files automatically, allowing the use of the Default engine without requiring compile_commands.json. I've included a suggested readme update.

Also removed a comma from the compile_commands.json configuration example which was causing a parsing error.

Fixes parsing error due to stray comma
Add wildcards to default Intellisense engine path to automatically discover all header files
https://code.visualstudio.com/docs/cpp/c-cpp-properties-schema-reference#_configuration-properties
Update configuration descriptions to reflect more flexible header discovery by using recursive search.
@pwmb pwmb added the enhancement New feature or request label Jan 1, 2020
@pwmb pwmb added this to the v0.1.3 milestone Jan 1, 2020
@github-actions github-actions bot changed the title Intellisense engine to search for headers automatically Intellisense engine to search for headers automatically (VSC-165) Jan 6, 2020
@pwmb pwmb requested a review from brianignacio5 January 7, 2020 04:26
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pwmb pwmb merged commit 3cc11ca into espressif:master Jan 19, 2020
brianignacio5 pushed a commit to brianignacio5/vscode-esp-idf-extension that referenced this pull request Mar 3, 2020
pwmb added a commit that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants