[3.1 -> main] fix libff in 3.1 tester cmakes #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el.cdt. Update CMakeLists.txt to create a parallel mandel-config.cmake for use until mandel goes through renaming. Update path to libff in fc libraries when using build from src. Add install directions for current mandel use with mandel.cdt (or others).
Mandel dev install is no longer the recommendation. For users utilizing native contract unit testing, make install no longer installs the required header and libraries. It's recommended to utilize the headers and libraries directly from mandel's build directory, or to use the mandel-dev package. Installation of these headers and libraries can still be performed with a make dev-install if absolutely needed.
fix libff in 3.1 tester cmakes
spoonincode
approved these changes
Jun 24, 2022
|
@oschwaldp-oci: For the future, don't create a PR to directly merge in a release/* branch into main. From my experience, there are problems that could arise with that approach. In addition, if you need to make changes to resolve conflicts specific to main, you will be forced to switch to another branch anyway. So always create a branch off of main with some appropriate name and then merge the release branch into it. Then resolve any issues within that branch and create a PR from that branch to the main branch. |
|
To be clear you are saying you want this approach:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues seen with libff when trying to use mandel with mandel.cdt.
Update CMakeLists.txt to create a parallel mandel-config.cmake for use until mandel goes through renaming.
Update path to libff in fc libraries when using build from src.
Add install directions for current mandel use with mandel.cdt (or others).
Resolves: #426
Resolves: #420
Supersedes: #421
Relates to mandel.cdt issue/PR:
eosnetworkfoundation/mandel.cdt#25
eosnetworkfoundation/mandel.cdt#26