Fixes for mandel.cdt integration tests #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut not mandel itself to allow mandel.cdt to build/link integration tests
This was referenced Jun 17, 2022
jgiszczak
approved these changes
Jun 17, 2022
larryk85
approved these changes
Jun 17, 2022
spoonincode
suggested changes
Jun 17, 2022
| @@ -60,7 +60,7 @@ else() | |||
| find_library(libsecp256k1 secp256k1 @CMAKE_BINARY_DIR@/libraries/fc/secp256k1 NO_DEFAULT_PATH) | |||
| endif() | |||
|
|
|||
| find_library(libff ff @CMAKE_BINARY_DIR@/libraries/fc/libraries/ff NO_DEFAULT_PATH) | |||
| find_library(libff ff @CMAKE_BINARY_DIR@/libraries/fc/libraries/ff/libff NO_DEFAULT_PATH) | |||
There was a problem hiding this comment.
does the other tester cmake need to be changed?
There was a problem hiding this comment.
Not if the 'dev' component is installed to the typical /usr/local. I am updating the README for current install instructions to make this work.
…dev components for use with other repos like mandel.cdt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #420
Parallel issue in mandel.cdt: eosnetworkfoundation/mandel.cdt#23
Related PR: eosnetworkfoundation/mandel.cdt#24