Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix libff in 3.1 tester cmakes #426

Closed
spoonincode opened this issue Jun 17, 2022 · 0 comments · Fixed by #530
Closed

fix libff in 3.1 tester cmakes #426

spoonincode opened this issue Jun 17, 2022 · 0 comments · Fixed by #530
Assignees
@oschwaldp-oci
Labels
3.1 Candidates 3.1 RC2 OCI OCI working this issue...
Milestone
Mandel 3.1.0

Comments

@spoonincode
Copy link
Member

spoonincode commented Jun 17, 2022 •
edited
Loading

it looks like there might be a problem with tester cmakes in 3.1rc1 based on main's #421
@spoonincode spoonincode mentioned this issue Jun 17, 2022
Closed
@tedcahalleos tedcahalleos added the OCI OCI working this issue... label Jun 21, 2022
@oschwaldp-oci oschwaldp-oci self-assigned this Jun 21, 2022
oschwaldp-oci added a commit that referenced this issue Jun 22, 2022
@oschwaldp-oci
GH-426 Fix issues seen with libff when trying to use mandel with mand…
1949a99 
…el.cdt.

Update CMakeLists.txt to create a parallel mandel-config.cmake for use until mandel goes through renaming.

Update path to libff in fc libraries when using build from src.

Add install directions for current mandel use with mandel.cdt (or others).
@oschwaldp-oci oschwaldp-oci mentioned this issue Jun 22, 2022
Merged
oschwaldp-oci added a commit that referenced this issue Jun 22, 2022
@oschwaldp-oci
GH-426 - Forgot CMAKE_INSTALL_PREFIX.
5f05de1
oschwaldp-oci added a commit that referenced this issue Jun 22, 2022
@oschwaldp-oci
GH-426 - Combine install commands into one-liner.
b955a8b
oschwaldp-oci added a commit that referenced this issue Jun 23, 2022
@oschwaldp-oci
GH-426 - Genericize install location and add more detailed instructions.
2d05d35
This was referenced Jun 23, 2022
Closed
Merged
oschwaldp-oci added a commit that referenced this issue Jun 23, 2022
@oschwaldp-oci
GH-426 - Remove notes on mandel dev install.
697e036 
Mandel dev install is no longer the recommendation.

For users utilizing native contract unit testing, make install no longer installs the required header and libraries. It's recommended to utilize the headers and libraries directly from mandel's build directory, or to use the mandel-dev package. Installation of these headers and libraries can still be performed with a make dev-install if absolutely needed.
@oschwaldp-oci oschwaldp-oci mentioned this issue Jun 24, 2022
Merged
@arhag arhag added this to the Mandel 3.1.0 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oschwaldp-oci oschwaldp-oci

Labels
3.1 Candidates 3.1 RC2 OCI OCI working this issue...
Projects
None yet
Milestone
Mandel 3.1.0
Development

Successfully merging a pull request may close this issue.

[3.1 -> main] fix libff in 3.1 tester cmakes eosnetworkfoundation/mandel
5 participants
@arhag @oschwaldp-oci @matthewdarwin @spoonincode @tedcahalleos