Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bp/1.29] jwt: do not concatenate duplicated headers (#32248) #32365

jwt: do not concatenate duplicated headers (#32248)

486d5fa
Select commit
Loading
Failed to load commit list.
Merged

[bp/1.29] jwt: do not concatenate duplicated headers (#32248) #32365

jwt: do not concatenate duplicated headers (#32248)
486d5fa
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Windows succeeded Feb 13, 2024 in 1h 53m 16s

Envoy/Windows (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Envoy/Windows (pr/32365/release/v1.29@486d5fa)

Check started by

Request (pr/32365/release/v1.29@486d5fa)

jewertow @jewertow 486d5fa #32365 merge release/v1.29@faf24ad

[bp/1.29] jwt: do not concatenate duplicated headers (#32248)

Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes #31468.

Risk Level:
Testing: unit tests
Docs Changes: none
Release Notes:
Platform Specific Features: none

Environment

Request variables

Key Value
ref 934f74ee53f8eadd83634aff5d8785f1c2262b27
sha 486d5fa
pr 32365
base-sha faf24ad
actor jewertow @jewertow
message [bp/1.29] jwt: do not concatenate duplicated headers (#32248)...
started 1707835560.519866
target-branch release/v1.29
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64
mobile envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 29
patch 2
dev true