[bp/1.29] jwt: do not concatenate duplicated headers (#32248) #32365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jewertow you will need to rebase to the release branch (force pushing is fine on backports as we want to preserve the commit) same for the other bp - thanks |
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes envoyproxy#31468. Risk Level: Testing: unit tests Docs Changes: none Release Notes: Platform Specific Features: none Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
8b175d1 to
486d5fa
Compare
|
@phlax done |
phlax
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes #31468.
Risk Level:
Testing: unit tests
Docs Changes: none
Release Notes:
Platform Specific Features: none